Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Issue 2704323003: Reland of Fixes a bug where a video stream can get stuck in the suspended state. (Closed)

Created:
3 years, 10 months ago by philipel
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Fixes a bug where a video stream can get stuck in the suspended state. (patchset #1 id:1 of https://codereview.chromium.org/2703393002/ ) Reason for revert: Downstream fixed Original issue's description: > Revert of Fixes a bug where a video stream can get stuck in the suspended state. (patchset #8 id:120001 of https://codereview.webrtc.org/2705603002/ ) > > Reason for revert: > Breaks downstream > > Original issue's description: > > Fixes a bug where a video stream can get stuck in the suspended state. > > > > This happens if a lot of FEC is allocated when the stream becomes suspended. The required bitrate to unsuspend can then be too high so that the padding bitrate we are allowed to generate is not enough. > > > > This CL also switches the tests from using ISAC to OPUS as RampUpTest.UpDownUpAudioVideoTransportSequenceNumberRtx relies on audio BWE to work (which is only compatible with OPUS). I don't know why it didn't fail before. > > > > BUG=webrtc:7178 > > > > Review-Url: https://codereview.webrtc.org/2705603002 > > Cr-Commit-Position: refs/heads/master@{#16739} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a518a39963d34616d8f0e94991c7f5fbb5affb38 > > TBR=mflodman@webrtc.org,terelius@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7178 > > Review-Url: https://codereview.webrtc.org/2703393002 > Cr-Commit-Position: refs/heads/master@{#16751} > Committed: https://chromium.googlesource.com/external/webrtc/+/b80bdcafed6c529be140da7d9f3e95a00b94219e TBR=mflodman@webrtc.org,terelius@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7178 Review-Url: https://codereview.webrtc.org/2704323003 Cr-Commit-Position: refs/heads/master@{#16753} Committed: https://chromium.googlesource.com/external/webrtc/+/5ef2bc191428928ee27f853c722f2ebd7d0a8a0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -87 lines) Patch
M webrtc/call/bitrate_allocator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 4 chunks +21 lines, -5 lines 0 comments Download
M webrtc/call/bitrate_allocator_unittest.cc View 5 chunks +3 lines, -5 lines 0 comments Download
M webrtc/call/rampup_tests.h View 5 chunks +20 lines, -2 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 13 chunks +130 lines, -52 lines 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/encoder_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_network_pipe.cc View 2 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
philipel
Created Reland of Fixes a bug where a video stream can get stuck in the ...
3 years, 10 months ago (2017-02-21 15:28:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2704323003/1
3 years, 10 months ago (2017-02-21 15:28:26 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 15:28:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5ef2bc191428928ee27f853c7...

Powered by Google App Engine
This is Rietveld 408576698