TrackMediaInfoMap: Allow same SSRC for send and receive side.

TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

I've verified that this fixes the bug.

BUG=chromium:693087
Review-Url: https://codereview.webrtc.org/2703783002
Cr-Commit-Position: refs/heads/master@{#16713}
Committed: https://chromium.googlesource.com/external/webrtc/+/fe90ad195f16e654e0b6281641b08d8821236308

[hbos, 2017-02-17 14:31:22]

Description was changed from

==========
TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

BUG=webrtc:693087
==========

to

==========
TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

I've verified that this fixes the bug.

BUG=webrtc:693087
==========

[hbos, 2017-02-17 14:31:23]

hbos@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[hbos, 2017-02-17 14:31:29]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 14:31:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2017-02-17 14:32:54]

Please take a look, deadbeef.

[hbos, 2017-02-17 14:34:51]

Example when running https://appr.tc/r/<room_id>?debug=loopback:

local audio track:  0x324d3c7e65c0, ssrc: 484724254
local video track:  0x324d3d5cb100, ssrc: -480451314
remote audio track: 0x324d3d4e00e0, ssrc: 484724254
remote video track: 0x324d3d6535d0, ssrc: -480451314

[hbos, 2017-02-17 14:36:05]

On 2017/02/17 14:34:51, hbos wrote:
> Example when running https://appr.tc/r/%3Croom_id%3E?debug=loopback:
> 
> local audio track:  0x324d3c7e65c0, ssrc: 484724254
> local video track:  0x324d3d5cb100, ssrc: -480451314
> remote audio track: 0x324d3d4e00e0, ssrc: 484724254
> remote video track: 0x324d3d6535d0, ssrc: -480451314

(converted from unsigned to signed when printf, ignore that it's negative...)

[hbos, 2017-02-17 14:37:50]

Description was changed from

==========
TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

I've verified that this fixes the bug.

BUG=webrtc:693087
==========

to

==========
TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

I've verified that this fixes the bug.

BUG=chromium:693087
==========

[commit-bot: I haz the power, 2017-02-17 16:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 16:31:41]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-02-17 17:23:53]

lgtm

[hbos, 2017-02-20 09:14:55]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2017-02-20 09:15:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-20 10:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487582095601010, "parent_rev":
"6aeef74b6e04bfa78a90b38b5d2323b24f0875d2", "commit_rev":
"fe90ad195f16e654e0b6281641b08d8821236308"}

[commit-bot: I haz the power, 2017-02-20 10:05:16]

Description was changed from

==========
TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

I've verified that this fixes the bug.

BUG=chromium:693087
==========

to

==========
TrackMediaInfoMap: Allow same SSRC for send and receive side.

Running video loopback on https://appr.tc/ revealed that it is possible
to use the same SSRC for a local and remote audio or video track. This
caused a DCHECK crash. The constructor of TrackMediaInfoMap is updated
to support this mapping and the unittest is updated (moved and modified
a test from being a death test to being a non-death test).

I've verified that this fixes the bug.

BUG=chromium:693087

Review-Url: https://codereview.webrtc.org/2703783002
Cr-Commit-Position: refs/heads/master@{#16713}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fe90ad195f16e654e0b628164...
==========

[commit-bot: I haz the power, 2017-02-20 10:05:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fe90ad195f16e654e0b628164...