Reduce usage of tmmbr information structure

Reduce usage of tmmbr information structure
by creating it on accepted tmmbr/tmmbn rtcp messages
rather on sender/receiver reports.

BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/2702373002
Cr-Commit-Position: refs/heads/master@{#16748}
Committed: https://chromium.googlesource.com/external/webrtc/+/ec067e9d2192902e7eaaee405ca0f4e5455f98c1

[danilchap, 2017-02-20 18:34:31]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 18:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[danilchap, 2017-02-20 18:39:56]

Description was changed from

==========
Create structore to store tmmbr/tmmbn on matching rtcp messages rather on sr/rr.

BUG=webrtc:5565
==========

to

==========
Reduce usage of tmmbr information structure
by creating it on accepted tmmbr/tmmbn rtcp messages
rather on sender/receiver reports.

BUG=webrtc:5565
==========

[danilchap, 2017-02-20 18:54:11]

danilchap@webrtc.org changed reviewers:
+ stefan@webrtc.org

[danilchap, 2017-02-20 18:54:11]

Should keep old behavior when tmmbr is used,
but shouldn't add anything to tmmbr_infos map when it isn't.

[commit-bot: I haz the power, 2017-02-20 20:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 20:38:07]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2017-02-21 12:10:51]

lgtm % nit

https://codereview.webrtc.org/2702373002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2702373002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:538:
RTCPReceiver::TmmbrInformation* RTCPReceiver::CreateTmmbrInformation(
Rename this FindOrCreateTmmbrInfo? (assuming both cases are still valid)

[danilchap, 2017-02-21 12:15:38]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2017-02-21 12:15:38]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2702373002/#ps40001 (title:
"CreateTmmbrInformation -> FindOrCreateTmmbrInfo")

[commit-bot: I haz the power, 2017-02-21 12:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[danilchap, 2017-02-21 12:15:48]

https://codereview.webrtc.org/2702373002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2702373002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:538:
RTCPReceiver::TmmbrInformation* RTCPReceiver::CreateTmmbrInformation(
On 2017/02/21 12:10:51, stefan-webrtc wrote:
> Rename this FindOrCreateTmmbrInfo? (assuming both cases are still valid)

Done.

[commit-bot: I haz the power, 2017-02-21 13:38:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487679338071820,
"parent_rev": "4e4dfbd45dd03316e4f3de59c8ecdd66493535ea", "commit_rev":
"ec067e9d2192902e7eaaee405ca0f4e5455f98c1"}

[commit-bot: I haz the power, 2017-02-21 13:38:22]

Description was changed from

==========
Reduce usage of tmmbr information structure
by creating it on accepted tmmbr/tmmbn rtcp messages
rather on sender/receiver reports.

BUG=webrtc:5565
==========

to

==========
Reduce usage of tmmbr information structure
by creating it on accepted tmmbr/tmmbn rtcp messages
rather on sender/receiver reports.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/2702373002
Cr-Commit-Position: refs/heads/master@{#16748}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ec067e9d2192902e7eaaee405...
==========

[commit-bot: I haz the power, 2017-02-21 13:38:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ec067e9d2192902e7eaaee405...