Move AudioDebugFileWriter from content/ to media/.

Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations on that thread.
* This is done in AudioInputController, thus its Create() functions and constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=694278
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2702323002
Cr-Commit-Position: refs/heads/master@{#452602}
Committed: https://chromium.googlesource.com/chromium/src/+/3d7b06a12ea2897550ef82afef840a06501ab544

[Henrik Grunell, 2017-02-20 15:28:48]

Description was changed from

==========
Move AudioDebugFileWriter from content/ to media/.

* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=
==========

to

==========
Move AudioDebugFileWriter from content/ to media/.

* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Henrik Grunell, 2017-02-20 15:32:21]

Patchset #1 (id:1) has been deleted

[Henrik Grunell, 2017-02-20 15:32:31]

Patchset #1 (id:20001) has been deleted

[Henrik Grunell, 2017-02-20 15:37:23]

Description was changed from

==========
Move AudioDebugFileWriter from content/ to media/.

* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Henrik Grunell, 2017-02-20 15:37:23]

grunell@chromium.org changed reviewers:
+ dalecurtis@chromium.org, olka@chromium.org, pfeldman@chromium.org

[Henrik Grunell, 2017-02-20 15:42:42]

Description was changed from

==========
Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=694278

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Henrik Grunell, 2017-02-20 15:44:43]

All: please take a look at the interfaces to begin with.

[Henrik Grunell, 2017-02-20 16:41:51]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 16:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 16:45:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 16:45:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Henrik Grunell, 2017-02-20 20:45:12]

On 2017/02/20 15:44:43, Henrik Grunell wrote:
> All: please take a look at the interfaces to begin with.

Dale: please advise on the dependency error, see for example
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

I don't see what I *should* include; media/media_features.h is for BUILDFLAG().

[o1ka, 2017-02-21 12:02:28]

On 2017/02/20 20:45:12, Henrik Grunell wrote:
> On 2017/02/20 15:44:43, Henrik Grunell wrote:
> > All: please take a look at the interfaces to begin with.
> 
> Dale: please advise on the dependency error, see for example
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> 
> I don't see what I *should* include; media/media_features.h is for
BUILDFLAG().

I think it's because media/audio does not have media in DEPS
(https://cs.chromium.org/chromium/src/media/audio/BUILD.gn?type=cs&l=136)
So you should probably include media/base/media_switches.h?

[o1ka, 2017-02-21 12:07:45]

To me the interfaces look generally fine. Nice cleanup!

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:29: const media::AudioParameters& params,
nit: remove media prefix everywhere in media namespace

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:53: struct DeleteOnFileThread;
Why do you need forward declarations if classes are declared just below?

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:61: class AudioFileWriter {
Why is it needed in the header?

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:105:
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;
just |task_runner_|?

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:112: if
(!ptr->file_task_runner()->DeleteSoon(FROM_HERE, ptr)) {
Move implementation to cc?

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:112: if
(!ptr->file_task_runner()->DeleteSoon(FROM_HERE, ptr)) {
Initialize struct with the task runner, instead of having getter?
In this case it can be called "DeleteOnThread" or "OnThreadDeleter".

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:124: const media::AudioParameters params_;
nit: media:: not needed

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:127: // The task runner to do file IO
operations on.
just O operations, not I, right? :) we are only writing.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_controller.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
media/audio/audio_input_controller.h:266:
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner);
It may look more comprehensive to have two task runner parameters one after
another, but up to you.

[Henrik Grunell, 2017-02-21 12:35:21]

On 2017/02/21 12:02:28, o1ka wrote:
> On 2017/02/20 20:45:12, Henrik Grunell wrote:
> > On 2017/02/20 15:44:43, Henrik Grunell wrote:
> > > All: please take a look at the interfaces to begin with.
> > 
> > Dale: please advise on the dependency error, see for example
> >
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> > 
> > I don't see what I *should* include; media/media_features.h is for
> BUILDFLAG().
> 
> I think it's because media/audio does not have media in DEPS
> (https://cs.chromium.org/chromium/src/media/audio/BUILD.gn?type=cs&l=136)
> So you should probably include media/base/media_switches.h?

Yeah, something in base. media_switches.h looks most reasonable, but isn't quite
logical. Maybe add dep in //media/audio to //media:media_features? Dale? (Using
media_switches.h for now to be able to run try bots.)

[Henrik Grunell, 2017-02-21 14:10:52]

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:29: const media::AudioParameters& params,
On 2017/02/21 12:07:44, o1ka wrote:
> nit: remove media prefix everywhere in media namespace

Missed that. Done.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:53: struct DeleteOnFileThread;
On 2017/02/21 12:07:45, o1ka wrote:
> Why do you need forward declarations if classes are declared just below?

Because of the

using AudioFileWriterUniquePtr ...

statement, which needs to be before AudioFileWriter declaration, because of

AudioFileWriterUniquePtr Create().

AudioFileWriter declaration, in turn, needs to be before DeleteOnFileThread
declaration.

Anyway, I moved the AFW declaration and the deleter definition to the impl file.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:61: class AudioFileWriter {
On 2017/02/21 12:07:44, o1ka wrote:
> Why is it needed in the header?

It was because of the deleter definition below (called into it). Both are moved
now.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:105:
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;
On 2017/02/21 12:07:45, o1ka wrote:
> just |task_runner_|?

Sounds good, done.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:112: if
(!ptr->file_task_runner()->DeleteSoon(FROM_HERE, ptr)) {
On 2017/02/21 12:07:45, o1ka wrote:
> Move implementation to cc?

Ah, yes. Done. (The declaration needs to remain for

AudioFileWriterUniquePtr file_writer_;

below.)

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:112: if
(!ptr->file_task_runner()->DeleteSoon(FROM_HERE, ptr)) {
On 2017/02/21 12:07:45, o1ka wrote:
> Initialize struct with the task runner, instead of having getter?
> In this case it can be called "DeleteOnThread" or "OnThreadDeleter".

I started writing this change but didn't have time to finish it, continuing
tomorrow.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:124: const media::AudioParameters params_;
On 2017/02/21 12:07:45, o1ka wrote:
> nit: media:: not needed

Done.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:127: // The task runner to do file IO
operations on.
On 2017/02/21 12:07:44, o1ka wrote:
> just O operations, not I, right? :) we are only writing.

:) Sure, but I'd claim IO isn't a literal term in that sense. No point
bike-shedding - changed.

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_controller.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
media/audio/audio_input_controller.h:266:
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner);
On 2017/02/21 12:07:45, o1ka wrote:
> It may look more comprehensive to have two task runner parameters one after
> another, but up to you.

:) I actually started to move it that way when working on the original patch but
changed my mind and reverted. The rationale for the current ordering is that
debug recording related parameters come last. (|params| should be moved last as
the CreateForStream().)

However, I don't have strong opinions and can do either way.

I'll wait for Dale's review before possibly changing this.

[Henrik Grunell, 2017-02-21 14:11:03]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 14:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 17:16:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:16:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[DaleCurtis, 2017-02-21 18:00:58]

lgtm thanks!

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.cc (right):

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.cc:135: // Manages the debug recording file
and writes to it. Can be created on any
Do we still need this inner class setup?

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:1: // Copyright 2017 The Chromium Authors.
All rights reserved.
We don't update copyright when moving IIRC.

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:68: };
DISALLOW_COPY_AND_ASSIGN()

[DaleCurtis, 2017-02-21 18:01:52]

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_controller.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
media/audio/audio_input_controller.h:266:
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner);
On 2017/02/21 at 14:10:52, Henrik Grunell wrote:
> On 2017/02/21 12:07:45, o1ka wrote:
> > It may look more comprehensive to have two task runner parameters one after
> > another, but up to you.
> 
> :) I actually started to move it that way when working on the original patch
but changed my mind and reverted. The rationale for the current ordering is that
debug recording related parameters come last. (|params| should be moved last as
the CreateForStream().)
> 
> However, I don't have strong opinions and can do either way.
> 
> I'll wait for Dale's review before possibly changing this.

This is just going to be deleted in the next CL, so doesn't matter?

[Henrik Grunell, 2017-02-21 21:02:19]

pfeldman@: can you please review content/. (Sorry for poking - if possible it
would be really great to get review before night CET. :))

[pfeldman, 2017-02-21 21:05:16]

lgtm

[Henrik Grunell, 2017-02-21 21:07:53]

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
File media/audio/audio_input_controller.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_input...
media/audio/audio_input_controller.h:266:
scoped_refptr<base::SingleThreadTaskRunner> file_task_runner);
On 2017/02/21 18:01:52, DaleCurtis wrote:
> On 2017/02/21 at 14:10:52, Henrik Grunell wrote:
> > On 2017/02/21 12:07:45, o1ka wrote:
> > > It may look more comprehensive to have two task runner parameters one
after
> > > another, but up to you.
> > 
> > :) I actually started to move it that way when working on the original patch
> but changed my mind and reverted. The rationale for the current ordering is
that
> debug recording related parameters come last. (|params| should be moved last
as
> the CreateForStream().)
> > 
> > However, I don't have strong opinions and can do either way.
> > 
> > I'll wait for Dale's review before possibly changing this.
> 
> This is just going to be deleted in the next CL, so doesn't matter?

Right, agree. (To be exact: the second next CL; not in the output debug
recording CL.)

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.cc (right):

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.cc:135: // Manages the debug recording file
and writes to it. Can be created on any
On 2017/02/21 18:00:58, DaleCurtis wrote:
> Do we still need this inner class setup?

I don't think that has changed because of the move, or am I missing something?

[Henrik Grunell, 2017-02-21 21:10:37]

On 2017/02/21 21:05:16, pfeldman wrote:
> lgtm

Thanks a lot for the quick response!

[Henrik Grunell, 2017-02-22 10:47:43]

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:112: if
(!ptr->file_task_runner()->DeleteSoon(FROM_HERE, ptr)) {
On 2017/02/21 14:10:52, Henrik Grunell wrote:
> On 2017/02/21 12:07:45, o1ka wrote:
> > Initialize struct with the task runner, instead of having getter?
> > In this case it can be called "DeleteOnThread" or "OnThreadDeleter".
> 
> I started writing this change but didn't have time to finish it, continuing
> tomorrow.

Now done.

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
File media/audio/audio_debug_file_writer.h (right):

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:1: // Copyright 2017 The Chromium Authors.
All rights reserved.
On 2017/02/21 18:00:58, DaleCurtis wrote:
> We don't update copyright when moving IIRC.

Done.

https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
media/audio/audio_debug_file_writer.h:68: };
On 2017/02/21 18:00:58, DaleCurtis wrote:
> DISALLOW_COPY_AND_ASSIGN()

Done.

[Henrik Grunell, 2017-02-22 10:47:53]

The CQ bit was checked by grunell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 10:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-02-22 11:00:26]

On 2017/02/22 10:47:43, Henrik Grunell wrote:
>
https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
> File media/audio/audio_debug_file_writer.h (right):
> 
>
https://codereview.chromium.org/2702323002/diff/40001/media/audio/audio_debug...
> media/audio/audio_debug_file_writer.h:112: if
> (!ptr->file_task_runner()->DeleteSoon(FROM_HERE, ptr)) {
> On 2017/02/21 14:10:52, Henrik Grunell wrote:
> > On 2017/02/21 12:07:45, o1ka wrote:
> > > Initialize struct with the task runner, instead of having getter?
> > > In this case it can be called "DeleteOnThread" or "OnThreadDeleter".
> > 
> > I started writing this change but didn't have time to finish it, continuing
> > tomorrow.
> 
> Now done.
> 
>
https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
> File media/audio/audio_debug_file_writer.h (right):
> 
>
https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
> media/audio/audio_debug_file_writer.h:1: // Copyright 2017 The Chromium
Authors.
> All rights reserved.
> On 2017/02/21 18:00:58, DaleCurtis wrote:
> > We don't update copyright when moving IIRC.
> 
> Done.
> 
>
https://codereview.chromium.org/2702323002/diff/60001/media/audio/audio_debug...
> media/audio/audio_debug_file_writer.h:68: };
> On 2017/02/21 18:00:58, DaleCurtis wrote:
> > DISALLOW_COPY_AND_ASSIGN()
> 
> Done.

Great! lgtm

[commit-bot: I haz the power, 2017-02-22 12:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 12:40:33]

Dry run: This issue passed the CQ dry run.

[Henrik Grunell, 2017-02-23 18:26:05]

The CQ bit was checked by grunell@chromium.org

[Henrik Grunell, 2017-02-23 18:26:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2702323002/#ps80001
(title: "Code review, unit test fix and rebase.")

[commit-bot: I haz the power, 2017-02-23 18:26:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 20:15:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487874365491890,
"parent_rev": "f3f17d64c61c095f5d7542bb74e2e7137f339b14", "commit_rev":
"3d7b06a12ea2897550ef82afef840a06501ab544"}

[commit-bot: I haz the power, 2017-02-23 20:16:05]

Description was changed from

==========
Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=694278

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move AudioDebugFileWriter from content/ to media/.

* Move audio_debug_file_writer* to media/audio/.
* Remove media::AudioFileWriter interface.
* Pass FILE task runner from content to media to be able to perform operations
on that thread.
* This is done in AudioInputController, thus its Create() functions and
constructor are updated.
* AudioDebugFileWriter is now created in AudioInputController constructor.

BUG=694278

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2702323002
Cr-Commit-Position: refs/heads/master@{#452602}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d7b06a12ea2897550ef82afef84...
==========

[commit-bot: I haz the power, 2017-02-23 20:16:08]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3d7b06a12ea2897550ef82afef84...