Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2702153004: Remove non-ARC code from the codebase. (Closed)

Created:
3 years, 10 months ago by kthelgason
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove non-ARC code from the codebase. BUG=webrtc:7198 Review-Url: https://codereview.webrtc.org/2702153004 Cr-Commit-Position: refs/heads/master@{#16765} Committed: https://chromium.googlesource.com/external/webrtc/+/de6adbe0ba02a5a659db5f3abd809c668d146b69

Patch Set 1 #

Patch Set 2 : Remove non-ARC code from the codebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -56 lines) Patch
M webrtc/base/thread.cc View 1 5 chunks +26 lines, -44 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/mac/APPRTCAppDelegate.m View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/test/testsupport/iosfileutils.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kthelgason
Please take a look when time allows :)
3 years, 10 months ago (2017-02-21 08:15:24 UTC) #2
henrika_webrtc
LGTM
3 years, 10 months ago (2017-02-21 08:57:14 UTC) #7
kthelgason
Turns out the files originally removed were needed. thread.cc is a pure c++ file and ...
3 years, 10 months ago (2017-02-21 09:50:34 UTC) #8
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-21 13:33:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2702153004/20001
3 years, 10 months ago (2017-02-22 07:57:49 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:42:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/de6adbe0ba02a5a659db5f3ab...

Powered by Google App Engine
This is Rietveld 408576698