Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Issue 2701253002: Don't attempt to use "network binder" for sockets bound to "ANY" IP. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't attempt to use "network binder" for sockets bound to "ANY" IP. BUG=NONE Review-Url: https://codereview.webrtc.org/2701253002 Cr-Commit-Position: refs/heads/master@{#16760} Committed: https://chromium.googlesource.com/external/webrtc/+/9ffa13ff5ddacf6fb029b8e2ecceee15fdcb2160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M webrtc/base/physicalsocketserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/physicalsocketserver_unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
PTAL
3 years, 10 months ago (2017-02-19 10:20:46 UTC) #2
pthatcher1
lgtm
3 years, 10 months ago (2017-02-21 22:57:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2701253002/1
3 years, 10 months ago (2017-02-21 23:36:51 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 00:18:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9ffa13ff5ddacf6fb029b8e2e...

Powered by Google App Engine
This is Rietveld 408576698