Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2699713004: Move camera implementation details away from the public API. (Closed)

Created:
3 years, 10 months ago by sakal
Modified:
3 years, 10 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move camera implementation details away from the public API. Moves CameraCapturer, CameraSession, Camera1Session and Camera2Session away from the public API. BUG=webrtc:7172 Review-Url: https://codereview.webrtc.org/2699713004 Cr-Commit-Position: refs/heads/master@{#16723} Committed: https://chromium.googlesource.com/external/webrtc/+/8c01fe530e53488b75f4b64753696a12aa44c859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1286 lines) Patch
M webrtc/sdk/android/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
D webrtc/sdk/android/api/org/webrtc/Camera1Session.java View 1 chunk +0 lines, -336 lines 0 comments Download
D webrtc/sdk/android/api/org/webrtc/Camera2Session.java View 1 chunk +0 lines, -453 lines 0 comments Download
D webrtc/sdk/android/api/org/webrtc/CameraCapturer.java View 1 chunk +0 lines, -449 lines 0 comments Download
D webrtc/sdk/android/api/org/webrtc/CameraSession.java View 1 chunk +0 lines, -39 lines 0 comments Download
A + webrtc/sdk/android/src/java/org/webrtc/Camera1Session.java View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/sdk/android/src/java/org/webrtc/Camera2Session.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/sdk/android/src/java/org/webrtc/CameraCapturer.java View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/sdk/android/src/java/org/webrtc/CameraSession.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
sakal
PTAL
3 years, 10 months ago (2017-02-20 12:48:59 UTC) #7
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-20 13:33:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2699713004/1
3 years, 10 months ago (2017-02-20 13:33:31 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 15:04:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8c01fe530e53488b75f4b6475...

Powered by Google App Engine
This is Rietveld 408576698