Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 2699593007: Replace DCHECK with ASSERT_TRUE in vie_encoder_unittest.cc (Closed)

Created:
3 years, 10 months ago by perkj_webrtc
Modified:
3 years, 10 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace DCHECK with ASSERT_TRUE in vie_encoder_unittest.cc BUG=none TBR=sprang@webrtc.org Review-Url: https://codereview.webrtc.org/2699593007 Cr-Commit-Position: refs/heads/master@{#16656} Committed: https://chromium.googlesource.com/external/webrtc/+/070ba85f5b1de878262f893d22f916df24719f46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/video/vie_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
perkj_webrtc
please
3 years, 10 months ago (2017-02-16 22:32:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2699593007/1
3 years, 10 months ago (2017-02-16 22:33:01 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 23:46:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/070ba85f5b1de878262f893d2...

Powered by Google App Engine
This is Rietveld 408576698