Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2699533002: Revert of Add the url attribute to the IceCandidate (Java Wrapper) (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add the url attribute to the IceCandidate (Java Wrapper) (patchset #4 id:120001 of https://codereview.webrtc.org/2690593002/ ) Reason for revert: Breaks AppRTCMobile interoperability. The ICE candidate URL shouldn't be signaled between endpoints, it's only there for informational purposes. Original issue's description: > Add the url attribute to the IceCandidate (Java Wrapper) > > The url of the ICE server is added to the IceCandiate class. > This can be used to tell which server this candidate was gathered from. > > BUG=webrtc:7128 > > Review-Url: https://codereview.webrtc.org/2690593002 > Cr-Original-Commit-Position: refs/heads/master@{#16593} > Committed: https://chromium.googlesource.com/external/webrtc/+/8586c8ee88bfbf97dd310efb2034ac4e125d4865 > Review-Url: https://codereview.webrtc.org/2690593002 > Cr-Commit-Position: refs/heads/master@{#16615} > Committed: https://chromium.googlesource.com/external/webrtc/+/45efce01c76b2bd801a68ba58a4bbe85cdc2aa23 TBR=magjed@webrtc.org,zhihuang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7128 Review-Url: https://codereview.webrtc.org/2699533002 Cr-Commit-Position: refs/heads/master@{#16616} Committed: https://chromium.googlesource.com/external/webrtc/+/f0a539b0c8f6ff7ab69ea5009806068420296c4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/DirectRTCClient.java View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/IceCandidate.java View 1 chunk +1 line, -11 lines 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Revert of Add the url attribute to the IceCandidate (Java Wrapper)
3 years, 10 months ago (2017-02-14 22:13:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2699533002/1
3 years, 10 months ago (2017-02-14 22:13:50 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 22:14:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f0a539b0c8f6ff7ab69ea5009...

Powered by Google App Engine
This is Rietveld 408576698