Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2699383002: Remove buildbot annotation for video_quality_loopback_test.py (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 10 months ago
Reviewers:
mandermo
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove buildbot annotation for video_quality_loopback_test.py In https://codereview.webrtc.org/2704073002 an attempt was made to make the buildbot step show up as orange, which didn't work. The step showed up as a test failure, which will confuse sheriffs. BUG=webrtc:7185 TBR=mandermo@webrtc.org Review-Url: https://codereview.webrtc.org/2699383002 . Cr-Commit-Position: refs/heads/master@{#16699} Committed: https://chromium.googlesource.com/external/webrtc/+/5d43f74585563a18fdbe822bd5a6f36a5281a213

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/examples/androidtests/video_quality_loopback_test.py View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
kjellander_webrtc
Committed patchset #3 (id:40001) manually as 5d43f74585563a18fdbe822bd5a6f36a5281a213.
3 years, 10 months ago (2017-02-19 08:31:05 UTC) #2
kjellander_webrtc
3 years, 10 months ago (2017-02-20 07:23:43 UTC) #3
Message was sent while issue was closed.
On 2017/02/19 08:31:05, kjellander_webrtc wrote:
> Committed patchset #3 (id:40001) manually as
> 5d43f74585563a18fdbe822bd5a6f36a5281a213.

It appears this wasn't the problem causing the test being reported as a failure
on the bots. So we'll need to fix the test first, then we can re-enable it. Feel
free to revert this and the previous CL if you wish.

Powered by Google App Engine
This is Rietveld 408576698