Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2699093002: Updating system_wrappers/include/metrics.h docs (Closed)

Created:
3 years, 10 months ago by mbonadei
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Updating system_wrappers/include/metrics.h docs In the metrics.h documentation the target to include a default implementation of metrics was referring to the previous build system (gyp). Now it is updated to refer to the current target. BUG=None NOTRY=True TBR=henrika@webrtc.org Review-Url: https://codereview.webrtc.org/2699093002 Cr-Commit-Position: refs/heads/master@{#16766} Committed: https://chromium.googlesource.com/external/webrtc/+/1e5b0269a8eb605e52c3efe590ad9038b7e0fb87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/system_wrappers/include/metrics.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
mbonadei
Only a small change to the documentation.
3 years, 10 months ago (2017-02-17 10:24:14 UTC) #3
kjellander_webrtc
lgtm
3 years, 10 months ago (2017-02-19 09:08:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2699093002/1
3 years, 10 months ago (2017-02-20 08:10:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13728)
3 years, 10 months ago (2017-02-20 08:16:04 UTC) #8
mbonadei
Adding henrika@ for the lgtm from an owner.
3 years, 10 months ago (2017-02-20 08:23:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2699093002/1
3 years, 10 months ago (2017-02-22 08:52:17 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:55:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1e5b0269a8eb605e52c3efe59...

Powered by Google App Engine
This is Rietveld 408576698