Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2698743002: Fix neteq_speed_test.cc (Closed)

Created:
3 years, 10 months ago by ehmaldonado_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix neteq_speed_test.cc After https://codereview.webrtc.org/2340773002, the path from webrtc::test::ResourcePath in webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc is wrong. It is /path/to/repos/resources/audio_coding/testfile32kHz.pcm It should be /path/to/repos/webrtc-temp/src/resources/audio_coding/testfile32kHz.pcm. The middle part is missing. The reason this target is affected is because webrtc::test::SetExecutablePath(argv[0]); was not called. That call is necessary for us to know that the test is being run from src/ and not from out/Default (as is assumed, when that function is not called.) BUG=chromium:497757 R=kjellander@webrtc.org, henrik.lundin@webrtc.org Review-Url: https://codereview.webrtc.org/2698743002 Cr-Commit-Position: refs/heads/master@{#16641} Committed: https://chromium.googlesource.com/external/webrtc/+/454c1d6a2305b7f0c8395b8e76b9a8aaaf8ee258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_coding/neteq/test/neteq_speed_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
3 years, 10 months ago (2017-02-15 20:52:03 UTC) #3
kjellander_webrtc
lgtm Ideally we'd fix fileutils so webrtc::test::SetExecutablePath() is never needed, but obviously that's more work. ...
3 years, 10 months ago (2017-02-16 07:37:09 UTC) #4
hlundin-webrtc
lgtm But I think you should "anonymize" the example paths in the CL description a ...
3 years, 10 months ago (2017-02-16 08:28:52 UTC) #5
ehmaldonado_webrtc
On 2017/02/16 08:28:52, hlundin-webrtc wrote: > lgtm > > But I think you should "anonymize" ...
3 years, 10 months ago (2017-02-16 11:10:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2698743002/1
3 years, 10 months ago (2017-02-16 11:10:32 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 11:54:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/454c1d6a2305b7f0c8395b8e7...

Powered by Google App Engine
This is Rietveld 408576698