Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2698613004: Including extra_gn_args to log line. (Closed)

Created:
3 years, 10 months ago by mbonadei
Modified:
3 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Including extra_gn_args to log line. In a recent commit we added --extra-gn-args flag but we forgot to log the extra_gn_args variable and this can cause useless investigations. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2698613004 Cr-Commit-Position: refs/heads/master@{#16639} Committed: https://chromium.googlesource.com/external/webrtc/+/7b2797e7c79b04c6ad5ad1e2ba85b4db85f0e79a

Patch Set 1 #

Patch Set 2 : Refactoring (removing some duplication) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools-webrtc/ios/build_ios_libs.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mbonadei
3 years, 10 months ago (2017-02-16 09:33:01 UTC) #2
kjellander_webrtc
lgtm
3 years, 10 months ago (2017-02-16 09:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2698613004/20001
3 years, 10 months ago (2017-02-16 09:38:48 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 09:41:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7b2797e7c79b04c6ad5ad1e2b...

Powered by Google App Engine
This is Rietveld 408576698