Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2698333004: Revert of Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. (Closed)

Created:
3 years, 10 months ago by tommi
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. (patchset #24 id:440001 of https://codereview.webrtc.org/2695743003/ ) Reason for revert: The GetThreadCpuTimeTest.SingleThread and .TwoThreads tests are unfortunately flaky on Mac (maybe other platforms). See for example: https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/11271/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio https://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/10395/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/11271/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio Since it's late, I'll have to revert the CL to get the tree and trybots green (instead of only disabling the failing tests). Original issue's description: > Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. > > BUG=webrtc:7095 > > Review-Url: https://codereview.webrtc.org/2695743003 > Cr-Commit-Position: refs/heads/master@{#16665} > Committed: https://chromium.googlesource.com/external/webrtc/+/3ff474b72ba1b34027e8391b1014c2838af445d4 TBR=sprang@webrtc.org,mflodman@webrtc.org,deadbeef@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org,ilnik@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2698333004 Cr-Commit-Position: refs/heads/master@{#16679} Committed: https://chromium.googlesource.com/external/webrtc/+/658c3bb0aba00142284bd464d1e2d693e53f931e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -253 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D webrtc/base/cpu_time.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/base/cpu_time.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D webrtc/base/cpu_time_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tommi
Created Revert of Added GetCpuTime to base/ to get total CPU time consumed by process ...
3 years, 10 months ago (2017-02-17 22:59:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2698333004/1
3 years, 10 months ago (2017-02-17 22:59:14 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 22:59:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/658c3bb0aba00142284bd464d...

Powered by Google App Engine
This is Rietveld 408576698