DescriptionRevert of Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. (patchset #24 id:440001 of https://codereview.webrtc.org/2695743003/ )
Reason for revert:
The GetThreadCpuTimeTest.SingleThread and .TwoThreads tests are unfortunately flaky on Mac (maybe other platforms). See for example:
https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/11271/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio
https://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/10395/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio
https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/11271/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio
Since it's late, I'll have to revert the CL to get the tree and trybots green (instead of only disabling the failing tests).
Original issue's description:
> Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests.
>
> BUG=webrtc:7095
>
> Review-Url: https://codereview.webrtc.org/2695743003
> Cr-Commit-Position: refs/heads/master@{#16665}
> Committed: https://chromium.googlesource.com/external/webrtc/+/3ff474b72ba1b34027e8391b1014c2838af445d4
TBR=sprang@webrtc.org,mflodman@webrtc.org,deadbeef@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org,ilnik@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7095
Review-Url: https://codereview.webrtc.org/2698333004
Cr-Commit-Position: refs/heads/master@{#16679}
Committed: https://chromium.googlesource.com/external/webrtc/+/658c3bb0aba00142284bd464d1e2d693e53f931e
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|