Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2698223002:
Disable EndToEndTest.VerifyNackStats on linux memcheck. (Closed)
|
Created:
3 years, 10 months ago by philipel Modified:
3 years, 10 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDisable EndToEndTest.VerifyNackStats on linux memcheck.
BUG=webrtc:7145
NOTRY=True
Review-Url: https://codereview.webrtc.org/2698223002
Cr-Commit-Position: refs/heads/master@{#16644}
Committed: https://chromium.googlesource.com/external/webrtc/+/3399927a0953fe8ea7a19397a8090476eec36305
Patch Set 1 #
Total comments: 3
Patch Set 2 : . #Messages
Total messages: 17 (9 generated)
philipel@webrtc.org changed reviewers: + kjellander@webrtc.org
The CQ bit was checked by philipel@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Needs a change. And please only run linux_memcheck bot for changes like this (and NOTRY=True) https://codereview.webrtc.org/2698223002/diff/1/tools-webrtc/valgrind/gtest_e... File tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt (right): https://codereview.webrtc.org/2698223002/diff/1/tools-webrtc/valgrind/gtest_e... tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt:15: # https://bugs.chromium.org/p/webrtc/issues/detail?id=7145 This needs to be EndToEndTest.VerifyNackStats/* since it's a parametrized test. See the linux_memcheck run - the test is still executing.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.webrtc.org/2698223002/diff/1/tools-webrtc/valgrind/gtest_e... File tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt (right): https://codereview.webrtc.org/2698223002/diff/1/tools-webrtc/valgrind/gtest_e... tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt:15: # https://bugs.chromium.org/p/webrtc/issues/detail?id=7145 On 2017/02/16 10:59:52, kjellander_webrtc wrote: > This needs to be EndToEndTest.VerifyNackStats/* since it's a parametrized test. > > See the linux_memcheck run - the test is still executing. Does that mean that the already ignored tests (like the one on line 10) started to run when I parameterized EndToEndTest?
https://codereview.webrtc.org/2698223002/diff/1/tools-webrtc/valgrind/gtest_e... File tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt (right): https://codereview.webrtc.org/2698223002/diff/1/tools-webrtc/valgrind/gtest_e... tools-webrtc/valgrind/gtest_exclude/video_engine_tests.gtest-memcheck.txt:15: # https://bugs.chromium.org/p/webrtc/issues/detail?id=7145 On 2017/02/16 11:32:06, philipel wrote: > On 2017/02/16 10:59:52, kjellander_webrtc wrote: > > This needs to be EndToEndTest.VerifyNackStats/* since it's a parametrized > test. > > > > See the linux_memcheck run - the test is still executing. > > Does that mean that the already ignored tests (like the one on line 10) started > to run when I parameterized EndToEndTest? Just check the log of the linux_memcheck bot you ran. It confirms that those tests ran, yes: [ RUN ] TestWithNewVideoJitterBuffer/EndToEndTest.AssignsTransportSequenceNumbers/1 [ OK ] TestWithNewVideoJitterBuffer/EndToEndTest.AssignsTransportSequenceNumbers/1 (7676 ms)
Description was changed from ========== Disable EndToEndTest.VerifyNackStats on linux memcheck. BUG=webrtc:7145 ========== to ========== Disable EndToEndTest.VerifyNackStats on linux memcheck. BUG=webrtc:7145 NOTRY=True ==========
PTAL
lgtm
The CQ bit was checked by philipel@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487252101056750,
"parent_rev": "11bfc53cd9a82f73ecbee2232b87acbb1e83fa4c", "commit_rev":
"3399927a0953fe8ea7a19397a8090476eec36305"}
Message was sent while issue was closed.
Description was changed from ========== Disable EndToEndTest.VerifyNackStats on linux memcheck. BUG=webrtc:7145 NOTRY=True ========== to ========== Disable EndToEndTest.VerifyNackStats on linux memcheck. BUG=webrtc:7145 NOTRY=True Review-Url: https://codereview.webrtc.org/2698223002 Cr-Commit-Position: refs/heads/master@{#16644} Committed: https://chromium.googlesource.com/external/webrtc/+/3399927a0953fe8ea7a19397a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/3399927a0953fe8ea7a19397a... |
