Return "not implemented" error from BindSocketToNetwork properly.

Return "not implemented" error from BindSocketToNetwork properly.

Previously, was only checking the Android SDK version. But it also needs
to check for the presence of the connectivity manager service.

BUG=webrtc:7026
Review-Url: https://codereview.webrtc.org/2697943002
Cr-Commit-Position: refs/heads/master@{#16631}
Committed: https://chromium.googlesource.com/external/webrtc/+/43be94725fe316db11bff9387037972ed89cc394

[Taylor Brandstetter, 2017-02-14 23:10:32]

deadbeef@webrtc.org changed reviewers:
+ magjed@webrtc.org

[Taylor Brandstetter, 2017-02-14 23:10:32]

magjed: PTAL

The issue is that, on systems without a connectivity manager service,
"BindSocketToNetwork" was returning an error rather than simply "not
implemented", which after a recent change I made will be treated as "socket bind
failed".

[magjed_webrtc, 2017-02-15 12:27:26]

lgtm

https://codereview.webrtc.org/2697943002/diff/1/webrtc/sdk/android/src/jni/an...
File webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.cc (right):

https://codereview.webrtc.org/2697943002/diff/1/webrtc/sdk/android/src/jni/an...
webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.cc:248: if
(!jni()->CallBooleanMethod(*j_network_monitor_,
Maybe you should add a CHECK_EXCEPTION(jni()) after this.

[Taylor Brandstetter, 2017-02-15 18:32:24]

https://codereview.webrtc.org/2697943002/diff/1/webrtc/sdk/android/src/jni/an...
File webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.cc (right):

https://codereview.webrtc.org/2697943002/diff/1/webrtc/sdk/android/src/jni/an...
webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.cc:248: if
(!jni()->CallBooleanMethod(*j_network_monitor_,
On 2017/02/15 12:27:26, magjed_webrtc wrote:
> Maybe you should add a CHECK_EXCEPTION(jni()) after this.

Done.

[Taylor Brandstetter, 2017-02-15 18:32:28]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-15 18:32:29]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2697943002/#ps20001 (title:
"Adding CHECK_EXCEPTION")

[commit-bot: I haz the power, 2017-02-15 18:32:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-15 19:49:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487183548207540,
"parent_rev": "9c6ded1bb2c1daa204aec27112ef8cfee8e34ac1", "commit_rev":
"43be94725fe316db11bff9387037972ed89cc394"}

[commit-bot: I haz the power, 2017-02-15 19:49:37]

Description was changed from

==========
Return "not implemented" error from BindSocketToNetwork properly.

Previously, was only checking the Android SDK version. But it also needs
to check for the presence of the connectivity manager service.

BUG=webrtc:7026
==========

to

==========
Return "not implemented" error from BindSocketToNetwork properly.

Previously, was only checking the Android SDK version. But it also needs
to check for the presence of the connectivity manager service.

BUG=webrtc:7026

Review-Url: https://codereview.webrtc.org/2697943002
Cr-Commit-Position: refs/heads/master@{#16631}
Committed:
https://chromium.googlesource.com/external/webrtc/+/43be94725fe316db11bff9387...
==========

[commit-bot: I haz the power, 2017-02-15 19:49:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/43be94725fe316db11bff9387...