Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 2697453004: WebRtcVoiceEngineTest: Changed a static_cast to a checked_cast. (Closed)

Created:
3 years, 10 months ago by ossu
Modified:
3 years, 10 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVoiceEngineTest: Changed a static_cast to a checked_cast. Also two spelling fixes. This is a follow-up to https://codereview.webrtc.org/2669583002/ TBR=kwiberg@webrtc.org BUG=webrtc:5806 Review-Url: https://codereview.webrtc.org/2697453004 Cr-Commit-Position: refs/heads/master@{#16586} Committed: https://chromium.googlesource.com/external/webrtc/+/bcd88dbc01ee75f9c15a44dd392ee7cc68704021

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2697453004/20001
3 years, 10 months ago (2017-02-13 15:01:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/bcd88dbc01ee75f9c15a44dd392ee7cc68704021
3 years, 10 months ago (2017-02-13 15:04:08 UTC) #15
ossu
Just a quick follow-up to my previous CL.
3 years, 10 months ago (2017-02-13 15:06:53 UTC) #16
kwiberg-webrtc
3 years, 10 months ago (2017-02-13 15:09:03 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698