Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2697383004: Added kNotAProbe definiton to PacketInfo. (Closed)

Created:
3 years, 10 months ago by philipel
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added kNotAProbe definiton to PacketInfo. BUG=none NOTRY=True TBR=nisse@webrtc.org, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2697383004 Cr-Commit-Position: refs/heads/master@{#16668} Committed: https://chromium.googlesource.com/external/webrtc/+/4db68e609b21644cc828d62440d5151b03a8834d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2697383004/1
3 years, 10 months ago (2017-02-17 14:38:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/4db68e609b21644cc828d62440d5151b03a8834d
3 years, 10 months ago (2017-02-17 14:40:38 UTC) #6
nisse-webrtc
lgtm https://codereview.webrtc.org/2697383004/diff/1/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h File webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h (right): https://codereview.webrtc.org/2697383004/diff/1/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h#newcode281 webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h:281: static constexpr int kNotAProbe = -1; It would ...
3 years, 10 months ago (2017-02-17 14:49:04 UTC) #7
philipel
3 years, 10 months ago (2017-02-20 16:14:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2706823003/ by philipel@webrtc.org.

The reason for reverting is: Downstream fix landed..

Powered by Google App Engine
This is Rietveld 408576698