Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2697313003: Use rtc::ToString instead of std::to_string. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use rtc::ToString instead of std::to_string. std::to_string isn't usable in some versions of the Android NDK. BUG=webrtc:7174 TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2697313003 Cr-Commit-Position: refs/heads/master@{#16651} Committed: https://chromium.googlesource.com/external/webrtc/+/dbeeb701a28971c92458a2f970c523bf66f409da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/p2p/base/dtlstransportinternal.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/icetransportinternal.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-02-16 17:57:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2697313003/1
3 years, 10 months ago (2017-02-16 17:57:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/dbeeb701a28971c92458a2f970c523bf66f409da
3 years, 10 months ago (2017-02-16 19:10:56 UTC) #6
pthatcher1
3 years, 10 months ago (2017-02-17 18:06:26 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698