Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2696733002: Add H.264 high profile to the list of supported codecs before baseline profile. (Closed)

Created:
3 years, 10 months ago by AlexG
Modified:
3 years, 10 months ago
Reviewers:
skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, magjed_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add H.264 high profile to the list of supported codecs before baseline profile. To ensure compliance with older version high profile should appear in local SDP before baseline profile. BUG=b/34816463 Review-Url: https://codereview.webrtc.org/2696733002 Cr-Commit-Position: refs/heads/master@{#16596} Committed: https://chromium.googlesource.com/external/webrtc/+/06b7e5ce1f3430db60a9ee1d7a201b82798459c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 2 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
AlexG
PTAL
3 years, 10 months ago (2017-02-13 21:30:31 UTC) #2
AlexG
3 years, 10 months ago (2017-02-13 21:30:43 UTC) #3
skvlad
On 2017/02/13 21:30:43, AlexG wrote: lgtm. Alternatively, you could just insert() the high profile codec ...
3 years, 10 months ago (2017-02-13 21:34:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2696733002/1
3 years, 10 months ago (2017-02-13 21:47:28 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 23:13:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/06b7e5ce1f3430db60a9ee1d7...

Powered by Google App Engine
This is Rietveld 408576698