vp8_impl.cc: Enable postproc for arm.

vp8_impl.cc: Enable postproc for arm under field trial.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.

TBR=marpan@webrtc.org
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2696403002
Cr-Commit-Position: refs/heads/master@{#16962}
Committed: https://chromium.googlesource.com/external/webrtc/+/55eb6d621489730084927868fed195d3645a9ec9

[åsapersson, 2017-02-16 10:18:05]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 10:18:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-16 11:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 11:24:57]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-02-23 13:58:45]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm.

Use stronger deblocking level (3 -> 6) for low resolutions (<= 320x240).

BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm.
For resolutions:
(<= 640x360): enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
(> 640x360): enable VP8_MFQE.

On all platforms:
Use stronger deblocking level (3 -> 6) for low resolutions (<= 320x240).

BUG=webrtc:6634
==========

[åsapersson, 2017-02-23 13:59:48]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm.
For resolutions:
(<= 640x360): enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
(> 640x360): enable VP8_MFQE.

On all platforms:
Use stronger deblocking level (3 -> 6) for low resolutions (<= 320x240).

BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm.
For resolutions:
<= 640x360: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 640x360: enable VP8_MFQE.

On all platforms:
Use stronger deblocking level (3 -> 6) for low resolutions (<= 320x240).

BUG=webrtc:6634
==========

[åsapersson, 2017-02-24 09:21:28]

Patchset #2 (id:20001) has been deleted

[åsapersson, 2017-02-24 09:23:30]

Patchset #2 (id:40001) has been deleted

[åsapersson, 2017-02-24 14:03:31]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm.
For resolutions:
<= 640x360: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 640x360: enable VP8_MFQE.

On all platforms:
Use stronger deblocking level (3 -> 6) for low resolutions (<= 320x240).

BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm.
For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.


BUG=webrtc:6634
==========

[åsapersson, 2017-02-24 14:06:16]

Patchset #3 (id:80001) has been deleted

[åsapersson, 2017-02-24 16:06:38]

Patchset #3 (id:100001) has been deleted

[åsapersson, 2017-02-24 16:15:55]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm.
For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.


BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.


BUG=webrtc:6634
==========

[åsapersson, 2017-02-27 16:29:36]

Patchset #3 (id:120001) has been deleted

[åsapersson, 2017-02-27 16:30:16]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.


BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm under field trial.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.


BUG=webrtc:6634
==========

[åsapersson, 2017-02-27 16:30:16]

asapersson@webrtc.org changed reviewers:
+ brandtr@webrtc.org, marpan@webrtc.org

[marpan, 2017-02-27 17:43:13]

marpan@google.com changed reviewers:
+ marpan@google.com

[marpan, 2017-02-27 17:43:14]

lgtm

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1086: ppcfg.deblocking_level
= 3;
can remove this setting, as its set below (line 1091) and only used when
deblocking is on.

[brandtr, 2017-02-27 22:12:16]

brandtr@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[brandtr, 2017-02-27 22:12:17]

Looks good, but I have one question.

Also adding Alex.

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1041: flags =
VPX_CODEC_USE_POSTPROC;
This file seems to use a mix of {}-style, but here I think it would be clearer
to add the {}.

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1090: if (last_frame_width_ *
last_frame_height_ <= 320 * 240) {
Should we check the current frame size here, rather than the previous frame
size?

By checking |last_frame_width_| (and height), the first frame will always have
full postproc enabled. Should we check that last_frame_width_ != 0 (and same for
height) here?

[åsapersson, 2017-02-28 09:17:56]

Patchset #4 (id:160001) has been deleted

[åsapersson, 2017-02-28 13:36:39]

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right):

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1041: flags =
VPX_CODEC_USE_POSTPROC;
On 2017/02/27 22:12:17, brandtr wrote:
> This file seems to use a mix of {}-style, but here I think it would be clearer
> to add the {}.

Done.

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1086: ppcfg.deblocking_level
= 3;
On 2017/02/27 17:43:14, marpan wrote:
> can remove this setting, as its set below (line 1091) and only used when
> deblocking is on.

Done.

https://codereview.webrtc.org/2696403002/diff/140001/webrtc/modules/video_cod...
webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1090: if (last_frame_width_ *
last_frame_height_ <= 320 * 240) {
On 2017/02/27 22:12:17, brandtr wrote:
> Should we check the current frame size here, rather than the previous frame
> size?
> 
> By checking |last_frame_width_| (and height), the first frame will always have
> full postproc enabled. Should we check that last_frame_width_ != 0 (and same
for
> height) here?

The current frame size is known after decode. Added a check for > 0.

[brandtr, 2017-02-28 13:46:15]

lgtm

[AlexG, 2017-02-28 17:44:17]

lgtm

[åsapersson, 2017-03-01 10:44:20]

The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 10:44:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 11:20:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 11:20:21]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-03-01 15:13:19]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2017-03-01 15:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from marpan@google.com
Link to the patchset: https://codereview.webrtc.org/2696403002/#ps180001 (title:
"address comments")

[commit-bot: I haz the power, 2017-03-01 15:13:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-01 15:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 15:17:15]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14334)

[åsapersson, 2017-03-02 07:47:39]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm under field trial.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.


BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm under field trial.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.

TBR=marpan@webrtc.org
BUG=webrtc:6634
==========

[åsapersson, 2017-03-02 07:49:54]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2017-03-02 07:50:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 07:52:16]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1488440994777200,
"parent_rev": "0ef30eff415f04cb039148180663151b55c75e0d", "commit_rev":
"55eb6d621489730084927868fed195d3645a9ec9"}

[commit-bot: I haz the power, 2017-03-02 07:52:20]

Description was changed from

==========
vp8_impl.cc: Enable postproc for arm under field trial.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.

TBR=marpan@webrtc.org
BUG=webrtc:6634
==========

to

==========
vp8_impl.cc: Enable postproc for arm under field trial.

For resolutions:
<= 320x240: enable full postproc (VP8_MFQE, VP8_DEBLOCK, VP8_DEMACROBLOCK).
> 320x240: enable VP8_MFQE.

TBR=marpan@webrtc.org
BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/2696403002
Cr-Commit-Position: refs/heads/master@{#16962}
Committed:
https://chromium.googlesource.com/external/webrtc/+/55eb6d621489730084927868f...
==========

[commit-bot: I haz the power, 2017-03-02 07:52:21]

Committed patchset #4 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/55eb6d621489730084927868f...