Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: components/search_engines/keyword_table.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Remove dependency CL. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/keyword_table.cc
diff --git a/components/search_engines/keyword_table.cc b/components/search_engines/keyword_table.cc
index 8ca529c1fb14661f10cc79d96a787e94f57b9dc5..a93488706411c3c6d57a3924ad744a0d664e25c4 100644
--- a/components/search_engines/keyword_table.cc
+++ b/components/search_engines/keyword_table.cc
@@ -13,6 +13,7 @@
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -37,7 +38,7 @@ namespace {
const char kBuiltinKeywordVersion[] = "Builtin Keyword Version";
const std::string ColumnsForVersion(int version, bool concatenated) {
- std::vector<std::string> columns;
+ std::vector<base::StringPiece> columns;
columns.push_back("id");
columns.push_back("short_name");
« no previous file with comments | « components/safe_browsing_db/safe_browsing_prefs_unittest.cc ('k') | components/search_provider_logos/google_logo_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698