Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: components/safe_browsing_db/safe_browsing_prefs_unittest.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Remove dependency CL. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/core/browser/policy_error_map.cc ('k') | components/search_engines/keyword_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/safe_browsing_prefs_unittest.cc
diff --git a/components/safe_browsing_db/safe_browsing_prefs_unittest.cc b/components/safe_browsing_db/safe_browsing_prefs_unittest.cc
index 303f87826a56a507200fa39512ef77ba688ca6e7..b6b3a088b455102e3f1684667242fcf6edab6d42 100644
--- a/components/safe_browsing_db/safe_browsing_prefs_unittest.cc
+++ b/components/safe_browsing_db/safe_browsing_prefs_unittest.cc
@@ -6,6 +6,7 @@
#include <vector>
#include "base/command_line.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "base/test/scoped_feature_list.h"
#include "components/prefs/pref_registry_simple.h"
@@ -41,8 +42,8 @@ class SafeBrowsingPrefsTest : public ::testing::Test {
}
void ResetExperiments(bool can_show_scout, bool only_show_scout) {
- std::vector<std::string> enabled_features;
- std::vector<std::string> disabled_features;
+ std::vector<base::StringPiece> enabled_features;
+ std::vector<base::StringPiece> disabled_features;
auto* target_vector =
can_show_scout ? &enabled_features : &disabled_features;
« no previous file with comments | « components/policy/core/browser/policy_error_map.cc ('k') | components/search_engines/keyword_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698