Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2695873004:
Fix flaky ViEEncoder unit test. (Closed)
|
Created:
3 years, 10 months ago by kthelgason Modified:
3 years, 10 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix flaky ViEEncoder unit test.
The flaky test was introduced in ad9010c9836, and is essentially a race
where the ViE Encoder has already configured the quality scaler on the
encoder thread before we've updated the ScalingSettings. This CL adds
a forced reconfiguration of the quality scaler to avoid this issue.
BUG=None
TBR=sprang@webrtc.org
Review-Url: https://codereview.webrtc.org/2695873004
Cr-Commit-Position: refs/heads/master@{#16612}
Committed: https://chromium.googlesource.com/external/webrtc/+/b83797bd7a7239049dcdd8d39a304769c3270a41
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
kthelgason@webrtc.org changed reviewers: + kjellander@webrtc.org
Henrik, please take a look.
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...) android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/21294)
lgtm, but two comments: 1) don't we have a bug for this? 2) I'm not an owner here.
kjellander@webrtc.org changed reviewers: + sprang@webrtc.org
+sprang for owners. This test is increasingly annoying due to it's flakiness. Thanks for fixing.
Description was changed from ========== Fix flaky ViEEncoder unit test. The flaky test was introduced in ad9010c9836, and is essentially a race where the ViE Encoder has already configured the quality scaler on the encoder thread before we've updated the ScalingSettings. This CL adds a forced reconfiguration of the quality scaler to avoid this issue. BUG=None ========== to ========== Fix flaky ViEEncoder unit test. The flaky test was introduced in ad9010c9836, and is essentially a race where the ViE Encoder has already configured the quality scaler on the encoder thread before we've updated the ScalingSettings. This CL adds a forced reconfiguration of the quality scaler to avoid this issue. BUG=None TBR=sprang@webrtc.org ==========
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
TBRing sprang to get this landed so the build bots aren't complaining all night.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487101085419920, "parent_rev":
"5465ef5699b42382bd778c7d4ad5a70c3298459a", "commit_rev":
"b83797bd7a7239049dcdd8d39a304769c3270a41"}
Message was sent while issue was closed.
Description was changed from ========== Fix flaky ViEEncoder unit test. The flaky test was introduced in ad9010c9836, and is essentially a race where the ViE Encoder has already configured the quality scaler on the encoder thread before we've updated the ScalingSettings. This CL adds a forced reconfiguration of the quality scaler to avoid this issue. BUG=None TBR=sprang@webrtc.org ========== to ========== Fix flaky ViEEncoder unit test. The flaky test was introduced in ad9010c9836, and is essentially a race where the ViE Encoder has already configured the quality scaler on the encoder thread before we've updated the ScalingSettings. This CL adds a forced reconfiguration of the quality scaler to avoid this issue. BUG=None TBR=sprang@webrtc.org Review-Url: https://codereview.webrtc.org/2695873004 Cr-Commit-Position: refs/heads/master@{#16612} Committed: https://chromium.googlesource.com/external/webrtc/+/b83797bd7a7239049dcdd8d39... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/b83797bd7a7239049dcdd8d39...
Message was sent while issue was closed.
lgtm should that be BUG=chromium:689972, chromium:689915 ?
Message was sent while issue was closed.
On 2017/02/15 08:37:06, språng wrote: > lgtm > should that be BUG=chromium:689972, chromium:689915 ? Not really. The test I wrote was flaky, doesn't really have anything to do with the perf bugs. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
