Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2695713002:
Modify android video_quality_loopback_test to run commands from the src dir. (Closed)
|
Created:
3 years, 10 months ago by ehmaldonado_webrtc Modified:
3 years, 10 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionModify android video_quality_loopback_test to run commands from the src dir.
R=kjellander@webrtc.org, mandermo@webrtc.org
TBR=perkj@webrtc.org
BUG=chromium:685222
NOTRY=True
Review-Url: https://codereview.webrtc.org/2695713002
Cr-Commit-Position: refs/heads/master@{#16647}
Committed: https://chromium.googlesource.com/external/webrtc/+/d103f4ba4afc8928345baa14dcb05124c94481e9
Patch Set 1 #
Total comments: 3
Patch Set 2 : Get rid of source_dir flag. #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Modify android video_quality_loopback_test to run commands from the src dir. It seems like it failed on the buildbot because it was run from another directory. R=kjellander@webrtc.org, mandermo@webrtc.org BUG=chromium:685222 ========== to ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org BUG=chromium:685222 ==========
kjellander@google.com changed reviewers: + kjellander@google.com
https://codereview.webrtc.org/2695713002/diff/1/webrtc/examples/androidtests/... File webrtc/examples/androidtests/video_quality_loopback_test.py (right): https://codereview.webrtc.org/2695713002/diff/1/webrtc/examples/androidtests/... webrtc/examples/androidtests/video_quality_loopback_test.py:35: def _RunCommand(argv, cwd=SRC_DIR, **kwargs): The script supports --source_dir flag, which overrides this (I don't remember the use case for it though, you could ask mandermo@). But either way I think we should use the value of args.source_dir instead, or just remove the flag entirely.
https://codereview.webrtc.org/2695713002/diff/1/webrtc/examples/androidtests/... File webrtc/examples/androidtests/video_quality_loopback_test.py (right): https://codereview.webrtc.org/2695713002/diff/1/webrtc/examples/androidtests/... webrtc/examples/androidtests/video_quality_loopback_test.py:35: def _RunCommand(argv, cwd=SRC_DIR, **kwargs): On 2017/02/14 12:31:05, kjellander (google.com) wrote: > The script supports --source_dir flag, which overrides this (I don't remember > the use case for it though, you could ask mandermo@). But either way I think we > should use the value of args.source_dir instead, or just remove the flag > entirely. Was useful during the development to provide the source_dir. I agree that either args.source_dir should be used or args.source_dir should be removed.
https://codereview.webrtc.org/2695713002/diff/1/webrtc/examples/androidtests/... File webrtc/examples/androidtests/video_quality_loopback_test.py (right): https://codereview.webrtc.org/2695713002/diff/1/webrtc/examples/androidtests/... webrtc/examples/androidtests/video_quality_loopback_test.py:35: def _RunCommand(argv, cwd=SRC_DIR, **kwargs): On 2017/02/14 14:21:15, mandermo wrote: > On 2017/02/14 12:31:05, kjellander (http://google.com) wrote: > > The script supports --source_dir flag, which overrides this (I don't remember > > the use case for it though, you could ask mandermo@). But either way I think > we > > should use the value of args.source_dir instead, or just remove the flag > > entirely. > > Was useful during the development to provide the source_dir. I agree that either > args.source_dir should be used or args.source_dir should be removed. I say we just drop the flag then. It shouldn't be needed anymore I think.
PTAL
lgtm
lgtm
Description was changed from ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org BUG=chromium:685222 ========== to ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org BUG=chromium:685222 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13570)
Description was changed from ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org BUG=chromium:685222 NOTRY=True ========== to ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org TBR=perkj@webrtc.org BUG=chromium:685222 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487258287349760,
"parent_rev": "5c29a7aad13809caaaa29f02519daea432586280", "commit_rev":
"d103f4ba4afc8928345baa14dcb05124c94481e9"}
Message was sent while issue was closed.
Description was changed from ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org TBR=perkj@webrtc.org BUG=chromium:685222 NOTRY=True ========== to ========== Modify android video_quality_loopback_test to run commands from the src dir. R=kjellander@webrtc.org, mandermo@webrtc.org TBR=perkj@webrtc.org BUG=chromium:685222 NOTRY=True Review-Url: https://codereview.webrtc.org/2695713002 Cr-Commit-Position: refs/heads/master@{#16647} Committed: https://chromium.googlesource.com/external/webrtc/+/d103f4ba4afc8928345baa14d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/d103f4ba4afc8928345baa14d... |
