Change NtpTime representation to single uint64_t

Change NtpTime representation to single uint64_t
Add explicit conversions to/from uint64_t

uint64_t is natural type for NtpTime, including wrap on overflow.

BUG=None

Review-Url: https://codereview.webrtc.org/2695683002
Cr-Commit-Position: refs/heads/master@{#16624}
Committed: https://chromium.googlesource.com/external/webrtc/+/27260ced9fc3e57e51b6be7ca42ae71b28d742e7

[danilchap, 2017-02-13 11:52:18]

danilchap@webrtc.org changed reviewers:
+ perkj@webrtc.org

[perkj_webrtc, 2017-02-14 09:22:39]

https://codereview.webrtc.org/2695683002/diff/1/webrtc/system_wrappers/includ...
File webrtc/system_wrappers/include/ntp_time.h (right):

https://codereview.webrtc.org/2695683002/diff/1/webrtc/system_wrappers/includ...
webrtc/system_wrappers/include/ntp_time.h:19: static constexpr uint64_t kRate =
0x100000000;
What does rate mean here? Why it is public? Private and and explanation or
rename as kTicksPerSecond or something like that.

https://codereview.webrtc.org/2695683002/diff/1/webrtc/system_wrappers/includ...
webrtc/system_wrappers/include/ntp_time.h:37: return 1000 *
static_cast<int64_t>(seconds()) +
use kNumMillisecsPerSec from  timeutils.h instead of 1000.

[danilchap, 2017-02-14 15:00:42]

https://codereview.webrtc.org/2695683002/diff/1/webrtc/system_wrappers/includ...
File webrtc/system_wrappers/include/ntp_time.h (right):

https://codereview.webrtc.org/2695683002/diff/1/webrtc/system_wrappers/includ...
webrtc/system_wrappers/include/ntp_time.h:19: static constexpr uint64_t kRate =
0x100000000;
On 2017/02/14 09:22:39, perkj_webrtc wrote:
> What does rate mean here? Why it is public? Private and and explanation or
> rename as kTicksPerSecond or something like that.

renamed, prefer this constant public e.g. to calculate diff between two
NtpTimes.

https://codereview.webrtc.org/2695683002/diff/1/webrtc/system_wrappers/includ...
webrtc/system_wrappers/include/ntp_time.h:37: return 1000 *
static_cast<int64_t>(seconds()) +
On 2017/02/14 09:22:39, perkj_webrtc wrote:
> use kNumMillisecsPerSec from  timeutils.h instead of 1000. 

would like to avoid include extra header for a constant that simple, specially
that I try not to touch ToMs function in this CL.

[perkj_webrtc, 2017-02-15 06:19:39]

lgtm

[danilchap, 2017-02-15 08:36:55]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-02-15 08:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-15 09:18:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487147815900100,
"parent_rev": "6486ef50ac94066018618faf747f46de548bd55e", "commit_rev":
"27260ced9fc3e57e51b6be7ca42ae71b28d742e7"}

[commit-bot: I haz the power, 2017-02-15 09:18:19]

Description was changed from

==========
Change NtpTime representation to single uint64_t
Add explicit conversions to/from uint64_t

uint64_t is natural type for NtpTime, including wrap on overflow.

BUG=None
==========

to

==========
Change NtpTime representation to single uint64_t
Add explicit conversions to/from uint64_t

uint64_t is natural type for NtpTime, including wrap on overflow.

BUG=None

Review-Url: https://codereview.webrtc.org/2695683002
Cr-Commit-Position: refs/heads/master@{#16624}
Committed:
https://chromium.googlesource.com/external/webrtc/+/27260ced9fc3e57e51b6be7ca...
==========

[commit-bot: I haz the power, 2017-02-15 09:18:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/27260ced9fc3e57e51b6be7ca...