Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2695593012: Delete LoggingSocketAdapter (unused) and AsyncHttpsProxyServerSocket (unimplemented). (Closed)

Created:
3 years, 10 months ago by nisse-webrtc
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete LoggingSocketAdapter (unused) and AsyncHttpsProxyServerSocket (unimplemented). BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2695593012 Cr-Commit-Position: refs/heads/master@{#16708} Committed: https://chromium.googlesource.com/external/webrtc/+/e29dfb7e3680d1c22d51f2a3d0f1394d237967cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -107 lines) Patch
M webrtc/base/socketadapters.h View 2 chunks +0 lines, -43 lines 0 comments Download
M webrtc/base/socketadapters.cc View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nisse-webrtc
3 years, 10 months ago (2017-02-17 12:43:12 UTC) #2
pthatcher1
lgtm
3 years, 10 months ago (2017-02-17 18:07:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2695593012/1
3 years, 10 months ago (2017-02-20 07:39:15 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 08:30:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e29dfb7e3680d1c22d51f2a3d...

Powered by Google App Engine
This is Rietveld 408576698