Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2695573003: Fix check_package_boundaries presubmit test for Windows. (Closed)

Created:
3 years, 10 months ago by ehmaldonado_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix check_package_boundaries presubmit test for Windows. BUG=webrtc:6954 NOTRY=True Review-Url: https://codereview.webrtc.org/2695573003 Cr-Commit-Position: refs/heads/master@{#16581} Committed: https://chromium.googlesource.com/external/webrtc/+/f6ddbe77cbc54c8e5c99a1e0f833d9a25868d26e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools-webrtc/check_package_boundaries.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools-webrtc/check_package_boundaries_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ehmaldonado_webrtc
3 years, 10 months ago (2017-02-13 11:43:16 UTC) #4
tommi
rs lgtm - thanks for fixing! :)
3 years, 10 months ago (2017-02-13 12:08:06 UTC) #5
kjellander_webrtc
lgtm
3 years, 10 months ago (2017-02-13 12:19:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2695573003/40001
3 years, 10 months ago (2017-02-13 13:15:10 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 13:18:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f6ddbe77cbc54c8e5c99a1e0f...

Powered by Google App Engine
This is Rietveld 408576698