Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2695303002: Make iOS API Framework script use the src/ dir as cwd for commands. (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 10 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make iOS API Framework script use the src/ dir as cwd for commands. The recent infra CL https://chromium-review.googlesource.com/c/439266/ seems to have broken our bot. It's better the script doesn't have any assumptions on cwd when executing. BUG=None R=mbonadei@webrtc.org TBR=mbonadei@webrtc.org Review-Url: https://codereview.webrtc.org/2695303002 . Cr-Commit-Position: refs/heads/master@{#16632} Committed: https://chromium.googlesource.com/external/webrtc/+/368b5ffecc78a0a1053eb9c81cc335a269d30760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools-webrtc/ios/build_ios_libs.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
mbonadei
On 2017/02/15 19:43:02, kjellander_webrtc wrote: > mailto:kjellander@webrtc.org changed reviewers: > + mailto:mbonadei@webrtc.org lgtm and thank ...
3 years, 10 months ago (2017-02-15 19:50:36 UTC) #3
kjellander_webrtc
3 years, 10 months ago (2017-02-15 19:51:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
368b5ffecc78a0a1053eb9c81cc335a269d30760.

Powered by Google App Engine
This is Rietveld 408576698