Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2694753002: Delete httpclient.c and related files. (Closed)

Created:
3 years, 10 months ago by nisse-webrtc
Modified:
3 years, 10 months ago
Reviewers:
noahric, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete httpclient.c and related files. The files socketpool.h and diskcache.h also become unused, and are deleted together with their sources. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2694753002 Cr-Commit-Position: refs/heads/master@{#16601} Committed: https://chromium.googlesource.com/external/webrtc/+/1a95e61e37db012480a39386523aab5503369b99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2054 lines) Patch
M webrtc/base/BUILD.gn View 4 chunks +0 lines, -8 lines 0 comments Download
D webrtc/base/diskcache.h View 1 chunk +0 lines, -125 lines 0 comments Download
D webrtc/base/diskcache.cc View 1 chunk +0 lines, -347 lines 0 comments Download
D webrtc/base/diskcache_win32.h View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/base/diskcache_win32.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D webrtc/base/httpclient.h View 1 chunk +0 lines, -199 lines 0 comments Download
D webrtc/base/httpclient.cc View 1 chunk +0 lines, -836 lines 0 comments Download
D webrtc/base/socketpool.h View 1 chunk +0 lines, -143 lines 0 comments Download
D webrtc/base/socketpool.cc View 1 chunk +0 lines, -281 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
nisse-webrtc
Another attempt to delete these files. Thanks to Noah's work, internal dependencies are gone. I ...
3 years, 10 months ago (2017-02-13 14:16:31 UTC) #2
noahric
lgtm
3 years, 10 months ago (2017-02-13 16:41:38 UTC) #4
pthatcher1
lgtm
3 years, 10 months ago (2017-02-13 17:39:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2694753002/1
3 years, 10 months ago (2017-02-14 07:19:36 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 08:23:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1a95e61e37db012480a393865...

Powered by Google App Engine
This is Rietveld 408576698