Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2694103003: Un-break downstream project. (Closed)

Created:
3 years, 10 months ago by Zhi Huang
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix the build break by keeping the old Port::AddAddress method since the downstream application depends on it. Mark the old Port::AddAddress deprecated and will be removed after the applications stop replying on it. BUG=None. R=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2694103003 . Cr-Commit-Position: refs/heads/master@{#16598} Committed: https://chromium.googlesource.com/external/webrtc/+/2758c664b434c5af5bb2e8ecd577f831f173408c

Patch Set 1 : Fix the internal project. #

Patch Set 2 : Clearify the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M webrtc/p2p/base/port.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (11 generated)
Taylor Brandstetter
lgtm
3 years, 10 months ago (2017-02-14 01:09:38 UTC) #5
pbos-webrtc
3 years, 10 months ago (2017-02-14 01:33:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
2758c664b434c5af5bb2e8ecd577f831f173408c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698