Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2693213005: Rename some variables and methods in RTC event log. (Closed)

Created:
3 years, 10 months ago by terelius
Modified:
3 years, 10 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename some variables and methods in RTC event log. Rename loss based and delay based bwe updates in proto (and correspondingly in the C++ code). BUG=None

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Unset-upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -76 lines) Patch
M webrtc/logging/rtc_event_log/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 2 3 chunks +10 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 3 chunks +32 lines, -5 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.proto View 1 2 5 chunks +24 lines, -7 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 2 4 chunks +20 lines, -11 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 2 4 chunks +47 lines, -12 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 2 3 chunks +90 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 2 5 chunks +63 lines, -5 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 1 2 4 chunks +6 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 2 4 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (10 generated)
terelius
The CQ bit was checked by terelius@webrtc.org to run a CQ dry run
3 years, 10 months ago (2017-02-16 18:18:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2693213005/1
3 years, 10 months ago (2017-02-16 18:18:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-16 18:22:11 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/10117)
3 years, 10 months ago (2017-02-16 18:22:12 UTC) #4
terelius
The CQ bit was checked by terelius@webrtc.org to run a CQ dry run
3 years, 10 months ago (2017-02-17 11:50:50 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2693213005/20001
3 years, 10 months ago (2017-02-17 11:51:04 UTC) #6
terelius
The CQ bit was checked by terelius@webrtc.org to run a CQ dry run
3 years, 10 months ago (2017-02-17 11:55:19 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2693213005/40001
3 years, 10 months ago (2017-02-17 11:55:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-17 11:58:04 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 11:58:05 UTC) #10 
Dry run: Try jobs failed on following builders:
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

Powered by Google App Engine
This is Rietveld 408576698