webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc - Issue 2693213005: Rename some variables and methods in RTC event log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

Issue 2693213005: Rename some variables and methods in RTC event log. (Closed)

Patch Set: Unset-upstream Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc ('k') | webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

index ad8a6f9e77140d7a7af703c08df4d746be51c569..2c683fd34ba3662827e87d863114c015650277b7 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc

@@ -286,7 +286,7 @@ void SendSideBandwidthEstimation::UpdateEstimate(int64_t now_ms) {

last_fraction_loss_ != last_logged_fraction_loss_ ||

last_rtc_event_log_ms_ == -1 ||

now_ms - last_rtc_event_log_ms_ > kRtcEventLogPeriodMs) {

- event_log_->LogBwePacketLossEvent(capped_bitrate, last_fraction_loss_,

+ event_log_->LogLossBasedBweUpdate(capped_bitrate, last_fraction_loss_,

expected_packets_since_last_loss_update_);

last_logged_fraction_loss_ = last_fraction_loss_;

last_rtc_event_log_ms_ = now_ms;