Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2692923002: Changing some PeerConnection-related comments. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changing some PeerConnection-related comments. As recommended by nisse@ in comments on this CL: https://codereview.webrtc.org/2685093002/ BUG=None NOTRY=True TBR=nisse@webrtc.org Review-Url: https://codereview.webrtc.org/2692923002 Cr-Commit-Position: refs/heads/master@{#16589} Committed: https://chromium.googlesource.com/external/webrtc/+/39e14da919415793acf6a26787965a847a936dcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/pc/videocapturertracksource.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2692923002/1
3 years, 10 months ago (2017-02-13 17:46:45 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-13 17:46:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2692923002/1
3 years, 10 months ago (2017-02-13 17:47:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/39e14da919415793acf6a26787965a847a936dcb
3 years, 10 months ago (2017-02-13 17:50:05 UTC) #11
nisse-webrtc
lgtm
3 years, 10 months ago (2017-02-14 07:21:32 UTC) #13
nisse-webrtc
3 years, 10 months ago (2017-02-14 07:22:23 UTC) #14
Message was sent while issue was closed.
And thanks for the quick response!

Powered by Google App Engine
This is Rietveld 408576698