Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2692843003: Remove VideoRendererGui (Closed)

Created:
3 years, 10 months ago by magjed_webrtc
Modified:
3 years, 10 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoRendererGui This file is deprecated and use of it should be replaced with SurfaceViewRenderer instead. BUG=webrtc:7158 R=sakal@webrtc.org Review-Url: https://codereview.webrtc.org/2692843003 . Cr-Commit-Position: refs/heads/master@{#16611} Committed: https://chromium.googlesource.com/external/webrtc/+/5465ef5699b42382bd778c7d4ad5a70c3298459a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -629 lines) Patch
M webrtc/sdk/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/sdk/android/api/org/webrtc/VideoRendererGui.java View 1 chunk +0 lines, -628 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
magjed_webrtc
Sami - please take a look.
3 years, 10 months ago (2017-02-14 13:18:12 UTC) #3
sakal
lgtm We should probably create a bug for this so it gets into release notes ...
3 years, 10 months ago (2017-02-14 13:21:23 UTC) #4
magjed_webrtc
3 years, 10 months ago (2017-02-14 13:27:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5465ef5699b42382bd778c7d4ad5a70c3298459a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698