Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

BUG=chromium:690916
NOTRY=True

Review-Url: https://codereview.webrtc.org/2692443003
Cr-Commit-Position: refs/heads/master@{#16579}
Committed: https://chromium.googlesource.com/external/webrtc/+/585209b36ed7bc6b7023e8bc91837599c26de2e2

[mbonadei, 2017-02-10 15:20:33]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-02-13 07:21:06]

https://codereview.webrtc.org/2692443003/diff/1/tools-webrtc/ios/build_ios_li...
File tools-webrtc/ios/build_ios_libs.py (right):

https://codereview.webrtc.org/2692443003/diff/1/tools-webrtc/ios/build_ios_li...
tools-webrtc/ios/build_ios_libs.py:63: return parser.parse_args()
For the bots, we'll need another flag --extra-gn-args as well, similar to
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/andro...

That's because they need to pass a the goma_dir variable, since the bot's don't
use the default location for Goma.
We could pass use_goma=True to that one as well, but let's keep --use-goma for
better visibility to regular end-users (and to align with
tools-webrtc/android/build_aar.py).

[mbonadei, 2017-02-13 10:21:35]

PTAL.

https://codereview.webrtc.org/2692443003/diff/1/tools-webrtc/ios/build_ios_li...
File tools-webrtc/ios/build_ios_libs.py (right):

https://codereview.webrtc.org/2692443003/diff/1/tools-webrtc/ios/build_ios_li...
tools-webrtc/ios/build_ios_libs.py:63: return parser.parse_args()
On 2017/02/13 07:21:05, kjellander_webrtc wrote:
> For the bots, we'll need another flag --extra-gn-args as well, similar to
>
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/andro...
> 
> That's because they need to pass a the goma_dir variable, since the bot's
don't
> use the default location for Goma.
> We could pass use_goma=True to that one as well, but let's keep --use-goma for
> better visibility to regular end-users (and to align with
> tools-webrtc/android/build_aar.py).

Done.

https://codereview.webrtc.org/2692443003/diff/20001/tools-webrtc/ios/build_io...
File tools-webrtc/ios/build_ios_libs.py (left):

https://codereview.webrtc.org/2692443003/diff/20001/tools-webrtc/ios/build_io...
tools-webrtc/ios/build_ios_libs.py:37: CUSTOM_GN_OPTS = [] # example:
['some_option=foo bar', 'other_option=true']
I removed this. It seems that it was another way to accomplish what we are now
doing with --extra-gn-args.

[kjellander_webrtc, 2017-02-13 10:32:51]

Description was changed from

==========
Adding --use-goma flag to build_ios_libs.py

BUG=chromium:690916
==========

to

==========
Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

BUG=chromium:690916
==========

[kjellander_webrtc, 2017-02-13 10:34:10]

lgtm (I updated CL description for you)

Can you test it locally just to be sure the args are passed in the right way (no
need to complete the builds, just add a temporary print to verify).

I'd also like to get checked that passing two variables to --extra-gn-args works
(like --extra-args="foo=bar bar=baz" should work but result in an error when it
runs GN).

[mbonadei, 2017-02-13 12:00:46]

On 2017/02/13 10:34:10, kjellander_webrtc wrote:
> lgtm (I updated CL description for you)
> 
> Can you test it locally just to be sure the args are passed in the right way
(no
> need to complete the builds, just add a temporary print to verify).
> 
> I'd also like to get checked that passing two variables to --extra-gn-args
works
> (like --extra-args="foo=bar bar=baz" should work but result in an error when
it
> runs GN).

Thanks for updating the description.

Here is the test:
> python tools-webrtc/ios/build_ios_libs.py --extra-gn-args="foo=bar bar=baz"
[...]
['gn', 'gen',
'/usr/local/google/home/mbonadei/projects_checkout/webrtc/src/out_ios_libs/arm_libs',
'--args=target_os="ios" ios_enable_code_signing=false use_xcode_clang=true
is_component_build=false is_debug=false target_cpu="arm"
ios_deployment_target="8.0" rtc_libvpx_build_vp9=false enable_ios_bitcode=false
use_goma=false enable_dsyms=true enable_stripping=true foo=bar bar=baz']
[...]

It seems to work as expected.

[mbonadei, 2017-02-13 12:25:10]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-02-13 12:25:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2017-02-13 12:27:01]

On 2017/02/13 12:25:19, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

Please add NOTRY=True on tiny infrastructure changes like this. Our trybots
don't have the intelligence of figuring out that they don't need to run for
changes like this.

You could just run the ios_api_framework bot manually to be sure it doesn't
break.

[commit-bot: I haz the power, 2017-02-13 12:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 12:33:24]

Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[mbonadei, 2017-02-13 12:41:30]

Description was changed from

==========
Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

BUG=chromium:690916
==========

to

==========
Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

BUG=chromium:690916
NOTRY=True
==========

[mbonadei, 2017-02-13 12:55:32]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-02-13 12:55:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2692443003/#ps40001 (title:
"Fixing gn_args generation")

[commit-bot: I haz the power, 2017-02-13 12:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-13 12:59:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486990532382280,
"parent_rev": "06f240bc4f086d4da18d69602de4de75a4fabdd4", "commit_rev":
"585209b36ed7bc6b7023e8bc91837599c26de2e2"}

[commit-bot: I haz the power, 2017-02-13 12:59:31]

Description was changed from

==========
Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

BUG=chromium:690916
NOTRY=True
==========

to

==========
Adding --use-goma and --extra-gn-args flags to build_ios_libs.py

BUG=chromium:690916
NOTRY=True

Review-Url: https://codereview.webrtc.org/2692443003
Cr-Commit-Position: refs/heads/master@{#16579}
Committed:
https://chromium.googlesource.com/external/webrtc/+/585209b36ed7bc6b7023e8bc9...
==========

[commit-bot: I haz the power, 2017-02-13 12:59:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/585209b36ed7bc6b7023e8bc9...