Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2691393003: Improving parallelism when building with goma (Closed)

Created:
3 years, 10 months ago by mbonadei
Modified:
3 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improving parallelism when building with goma It seems that ninja defaults the number of available CPUs. BUG=chromium:690916 NOTRY=True Review-Url: https://codereview.webrtc.org/2691393003 Cr-Commit-Position: refs/heads/master@{#16635} Committed: https://chromium.googlesource.com/external/webrtc/+/8714b8f1aecbf04eec90d1fc86f151072d629120

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing typo 'j' -> '-j' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools-webrtc/ios/build_ios_libs.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjellander_webrtc
huh, is the trybot not building anything?! https://codereview.webrtc.org/2691393003/diff/1/tools-webrtc/ios/build_ios_libs.py File tools-webrtc/ios/build_ios_libs.py (right): https://codereview.webrtc.org/2691393003/diff/1/tools-webrtc/ios/build_ios_libs.py#newcode127 tools-webrtc/ios/build_ios_libs.py:127: cmd.extend(['j', '200']) ...
3 years, 10 months ago (2017-02-15 14:40:59 UTC) #2
mbonadei
On 2017/02/15 14:40:59, kjellander_webrtc wrote: > huh, is the trybot not building anything?! > > ...
3 years, 10 months ago (2017-02-15 14:43:25 UTC) #3
mbonadei
3 years, 10 months ago (2017-02-15 14:44:12 UTC) #4
kjellander_webrtc
lgtm, but let's wait for the recipe to be fixed first, then do another try ...
3 years, 10 months ago (2017-02-15 14:46:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2691393003/20001
3 years, 10 months ago (2017-02-15 21:16:02 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 21:19:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8714b8f1aecbf04eec90d1fc8...

Powered by Google App Engine
This is Rietveld 408576698