Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2690903004:
Added WebRTC-QuickPerfTest field trial. If enabled only 1 frame will be sent. (Closed)
DescriptionAdded WebRTC-QuickPerfTest field trial. If enabled only 1 frame will be sent.
BUG=webrtc:7101
Review-Url: https://codereview.webrtc.org/2690903004
Cr-Commit-Position: refs/heads/master@{#16622}
Committed: https://chromium.googlesource.com/external/webrtc/+/9ae0d76b9291c18dd30b7600f3c42ed18fc016be
Patch Set 1 #
Total comments: 4
Patch Set 2 : Implemented Sprang@ comments. #Messages
Total messages: 21 (11 generated)
ilnik@webrtc.org changed reviewers: + holmer@chromium.org, sprang@google.com
Description was changed from ========== Added WebRTC-quick field trial. If enabled only 1 frame will be sent. BUG=webrtc:7101 ========== to ========== Added WebRTC-quick field trial. If enabled only 1 frame will be sent. BUG=webrtc:7101 ==========
sprang@webrtc.org changed reviewers: + sprang@webrtc.org, stefan@webrtc.org - holmer@chromium.org, sprang@google.com
https://codereview.webrtc.org/2690903004/diff/1/webrtc/video/video_quality_te... File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2690903004/diff/1/webrtc/video/video_quality_te... webrtc/video/video_quality_test.cc:690: if (field_trial::FindFullName("WebRTC-quick") != "Enabled") { Can we make the name a bit more descriptive? Something like WebRTC-QuickPerfTest, maybe? https://codereview.webrtc.org/2690903004/diff/1/webrtc/video/video_quality_te... webrtc/video/video_quality_test.cc:1347: bool quick_tests = field_trial::FindFullName("WebRTC-quick") == "Enabled"; Maybe move this to the constants at the top, in the anonymous namespace. Then we don't have to parse the string in two places and risk mismatch.
https://codereview.webrtc.org/2690903004/diff/1/webrtc/video/video_quality_te... File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2690903004/diff/1/webrtc/video/video_quality_te... webrtc/video/video_quality_test.cc:690: if (field_trial::FindFullName("WebRTC-quick") != "Enabled") { On 2017/02/14 13:36:12, språng wrote: > Can we make the name a bit more descriptive? > Something like WebRTC-QuickPerfTest, maybe? Acknowledged. https://codereview.webrtc.org/2690903004/diff/1/webrtc/video/video_quality_te... webrtc/video/video_quality_test.cc:1347: bool quick_tests = field_trial::FindFullName("WebRTC-quick") == "Enabled"; On 2017/02/14 13:36:12, språng wrote: > Maybe move this to the constants at the top, in the anonymous namespace. Then we > don't have to parse the string in two places and risk mismatch. Acknowledged.
lgtm
The CQ bit was checked by ilnik@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...) android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/21293)
Description was changed from ========== Added WebRTC-quick field trial. If enabled only 1 frame will be sent. BUG=webrtc:7101 ========== to ========== Added WebRTC-QuickPerfTest field trial. If enabled only 1 frame will be sent. BUG=webrtc:7101 ==========
The CQ bit was checked by ilnik@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by ilnik@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487147788744690,
"parent_rev": "08b19dfc671306e37640a18250aeebefd4e6a92a", "commit_rev":
"9ae0d76b9291c18dd30b7600f3c42ed18fc016be"}
Message was sent while issue was closed.
Description was changed from ========== Added WebRTC-QuickPerfTest field trial. If enabled only 1 frame will be sent. BUG=webrtc:7101 ========== to ========== Added WebRTC-QuickPerfTest field trial. If enabled only 1 frame will be sent. BUG=webrtc:7101 Review-Url: https://codereview.webrtc.org/2690903004 Cr-Commit-Position: refs/heads/master@{#16622} Committed: https://chromium.googlesource.com/external/webrtc/+/9ae0d76b9291c18dd30b7600f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/9ae0d76b9291c18dd30b7600f... |
