Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2690183005: Reland of Roll chromium_revision 7a8b621535..962dfbcdb2 (449940:450031) (Closed)

Created:
3 years, 10 months ago by kjellander (google.com)
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Roll chromium_revision 7a8b621535..962dfbcdb2 (449940:450031) (patchset #1 id:1 of https://codereview.webrtc.org/2690243002/ ) Reason for revert: I have a fix ready for the downstream project. Original issue's description: > Revert of Roll chromium_revision 7a8b621535..962dfbcdb2 (449940:450031) (patchset #1 id:1 of https://codereview.webrtc.org/2694773003/ ) > > Reason for revert: > The libvpx roll broke an internal project > > Original issue's description: > > Roll chromium_revision 7a8b621535..962dfbcdb2 (449940:450031) > > > > Change log: https://chromium.googlesource.com/chromium/src/+log/7a8b621535..962dfbcdb2 > > Full diff: https://chromium.googlesource.com/chromium/src/+/7a8b621535..962dfbcdb2 > > > > Changed dependencies: > > * src/base: https://chromium.googlesource.com/chromium/src/base/+log/da9ea7c196..e7ee554267 > > * src/build: https://chromium.googlesource.com/chromium/src/build/+log/3e5cfce8cf..11f5df6e25 > > * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/aef3d8defa..ba6815a36f > > * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/a2296b7dbc..26d563eb01 > > * src/third_party/libvpx/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/164db8278f..91f87e7513 > > * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/8bbd3624b9..aceeebe907 > > DEPS diff: https://chromium.googlesource.com/chromium/src/+/7a8b621535..962dfbcdb2/DEPS > > > > No update to Clang. > > > > TBR=marpan@webrtc.org, > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/2694773003 > > Cr-Commit-Position: refs/heads/master@{#16590} > > Committed: https://chromium.googlesource.com/external/webrtc/+/9c9d95b2dcf6007de99ad640e2f0f48e69dcb9db > > TBR=marpan@webrtc.org,buildbot@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2690243002 > Cr-Commit-Position: refs/heads/master@{#16592} > Committed: https://chromium.googlesource.com/external/webrtc/+/02c739f4ef9735fb1453a2499e74c24f3cea4453 TBR=marpan@webrtc.org,buildbot@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2690183005 Cr-Commit-Position: refs/heads/master@{#16600} Committed: https://chromium.googlesource.com/external/webrtc/+/29ea2edfe6b54d9a3bbe9b79932a4a72a906e350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M DEPS View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander (google.com)
Created Reland of ll chromium_revision 7a8b621535..962dfbcdb2 (449940:450031)
3 years, 10 months ago (2017-02-14 07:50:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2690183005/1
3 years, 10 months ago (2017-02-14 07:52:44 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-14 07:52:46 UTC) #7
kjellander_webrtc
lgtm
3 years, 10 months ago (2017-02-14 07:53:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2690183005/1
3 years, 10 months ago (2017-02-14 07:53:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/29ea2edfe6b54d9a3bbe9b79932a4a72a906e350
3 years, 10 months ago (2017-02-14 07:53:23 UTC) #13
kjellander_webrtc
3 years, 10 months ago (2017-02-14 12:53:19 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2691933005/ by kjellander@webrtc.org.

The reason for reverting is: Downstream fix needs to wait, so revert again to
green up..

Powered by Google App Engine
This is Rietveld 408576698