Handle InitDecode and reset in fallback decoder.

Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

BUG=webrtc:7154
R=noahric@chromium.org, sophiechang@chromium.org

Review-Url: https://codereview.webrtc.org/2690183004 .
Cr-Commit-Position: refs/heads/master@{#16594}
Committed: https://chromium.googlesource.com/external/webrtc/+/f812e45d8f1b876a52787884fc529feb37ba6135

[pbos-webrtc, 2017-02-13 20:13:30]

Description was changed from

==========
Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

R=noahric@chromium.org, stefan@webrtc.org
BUG=
==========

to

==========
Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

R=noahric@chromium.org, sophiechang@chromium.org, stefan@webrtc.org
BUG=
==========

[pbos-webrtc, 2017-02-13 20:13:31]

pbos@webrtc.org changed reviewers:
+ sophiechang@chromium.org

[pbos-webrtc, 2017-02-13 20:13:38]

PTAL

[pbos-webrtc, 2017-02-13 20:13:43]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 20:13:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-13 20:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 20:20:02]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13418)

[pbos-webrtc, 2017-02-13 20:27:20]

remove local puts

[sophiechang-webrtc, 2017-02-13 20:40:26]

lgtm

[noahric, 2017-02-13 20:42:30]

lgtm

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
File webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc (right):

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc:81: puts("::Decode no
fallback");
Remove puts.

Though I would add an LS_INFO line in the reinit block.

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc:123: int32_t
VideoDecoderSoftwareFallbackWrapper::Release() {
While you're here, it'd be nice to have an LS_INFO at the top of this function,
if release really isn't logged elsewhere (maybe you can infer it form some
generic_decoder.cc logs, but it wasn't obvious to me).

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
File webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc
(right):

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc:96: //
Unfortunately faking a VP8 frame is hard. Rely on no Decode -> using SW
Makes sense, just check the result of fallback_wrapper_.Decode.

[pbos-webrtc, 2017-02-13 20:48:46]

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
File webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc (right):

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc:81: puts("::Decode no
fallback");
On 2017/02/13 20:42:29, noahric wrote:
> Remove puts.
> 
> Though I would add an LS_INFO line in the reinit block.

I put it when fallback_decoder_ is removed, don't want it spamming per keyframe
reinit attempt.

https://codereview.webrtc.org/2690183004/diff/1/webrtc/media/engine/videodeco...
webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc:123: int32_t
VideoDecoderSoftwareFallbackWrapper::Release() {
On 2017/02/13 20:42:29, noahric wrote:
> While you're here, it'd be nice to have an LS_INFO at the top of this
function,
> if release really isn't logged elsewhere (maybe you can infer it form some
> generic_decoder.cc logs, but it wasn't obvious to me).

Adding one specifically for removing the fallback decoder, another should maybe
be re-added in generic_decoder.cc but we can do that separately.

[pbos-webrtc, 2017-02-13 20:52:43]

Description was changed from

==========
Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

R=noahric@chromium.org, sophiechang@chromium.org, stefan@webrtc.org
BUG=
==========

to

==========
Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

BUG=webrtc:7154
R=noahric@chromium.org, sophiechang@chromium.org
==========

[pbos-webrtc, 2017-02-13 20:52:54]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 20:53:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[pbos-webrtc, 2017-02-13 22:11:10]

Description was changed from

==========
Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

BUG=webrtc:7154
R=noahric@chromium.org, sophiechang@chromium.org
==========

to

==========
Handle InitDecode and reset in fallback decoder.

Makes sure video decoder software fallback handles InitDecode()
failures, and properly releases the pointer after ::Release() so that
another decode failure will properly reinitialize the decoder.

Also makes sure to not call Decode() without a previous InitDecode()
succeeding.

BUG=webrtc:7154
R=noahric@chromium.org, sophiechang@chromium.org

Review-Url: https://codereview.webrtc.org/2690183004 .
Cr-Commit-Position: refs/heads/master@{#16594}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f812e45d8f1b876a52787884f...
==========

[pbos-webrtc, 2017-02-13 22:11:11]

Committed patchset #4 (id:60001) manually as
f812e45d8f1b876a52787884fc529feb37ba6135 (presubmit successful).