Chromium Code Reviews

Issue 2690023002: Fix nits in vie_encoder (Closed)

Created:
3 years, 10 months ago by sprang_webrtc
Modified:
3 years, 10 months ago
Reviewers:
ilnik
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix nits in vie_encoder Updated comment. Don't call AdaptUp/AdaptDown in tests without first emitting a frame. Handle frame received precondition in AdaptUp/AdaptDown with DCHECK instead of return. BUG=webrtc:4172, webrtc:6850 Review-Url: https://codereview.webrtc.org/2690023002 Cr-Commit-Position: refs/heads/master@{#16572} Committed: https://chromium.googlesource.com/external/webrtc/+/be03724ae1a1fc677d15ff77a90b0e578d98c4ce

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+10 lines, -11 lines)
M webrtc/video/vie_encoder.cc View 3 chunks +10 lines, -9 lines 0 comments
M webrtc/video/vie_encoder_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments

Messages

Total messages: 12 (8 generated)
sprang_webrtc
3 years, 10 months ago (2017-02-13 10:06:19 UTC) #4
ilnik
On 2017/02/13 10:06:19, språng wrote: lgtm
3 years, 10 months ago (2017-02-13 10:32:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2690023002/1
3 years, 10 months ago (2017-02-13 10:35:44 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 10:38:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/be03724ae1a1fc677d15ff77a...

Powered by Google App Engine