Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2689503002: Removing unnecessary parameters from CreateXChannel methods. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing unnecessary parameters from CreateXChannel methods. "bundle_transport_name" is no longer relevant here, and "rtcp_mux_required" is implied by whether or not an RTCP transport is passed in. BUG=None Review-Url: https://codereview.webrtc.org/2689503002 Cr-Commit-Position: refs/heads/master@{#16551} Committed: https://chromium.googlesource.com/external/webrtc/+/1a2183d0c32489ee4253c806b46225a24b654764

Patch Set 1 #

Patch Set 2 : Anonymous namespace #

Patch Set 3 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -57 lines) Patch
M webrtc/pc/channelmanager.h View 1 2 6 chunks +0 lines, -12 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 9 chunks +8 lines, -21 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 1 3 chunks +11 lines, -14 lines 0 comments Download
M webrtc/pc/rtpsenderreceiver_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/pc/webrtcsession.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (5 generated)
pthatcher1
lgtm
3 years, 10 months ago (2017-02-10 18:22:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2689503002/40001
3 years, 10 months ago (2017-02-11 07:04:18 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 07:44:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1a2183d0c32489ee4253c806b...

Powered by Google App Engine
This is Rietveld 408576698