Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2689183002: Clean out platform specific things from voice_engine_defines.h. (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean out platform specific things from voice_engine_defines.h. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2689183002 Cr-Commit-Position: refs/heads/master@{#16578} Committed: https://chromium.googlesource.com/external/webrtc/+/06f240bc4f086d4da18d69602de4de75a4fabdd4

Patch Set 1 #

Patch Set 2 : more remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -226 lines) Patch
M webrtc/audio/audio_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/codec_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/dtmf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_defines.h View 1 6 chunks +2 lines, -217 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
the sun
3 years, 10 months ago (2017-02-13 10:14:18 UTC) #4
henrika_webrtc
lgtm
3 years, 10 months ago (2017-02-13 10:25:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2689183002/20001
3 years, 10 months ago (2017-02-13 11:57:11 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 12:42:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/06f240bc4f086d4da18d69602...

Powered by Google App Engine
This is Rietveld 408576698