Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2687483002: Revert of RTCInboundRTPStreamStats.qpSum collected. (Closed)

Created:
3 years, 10 months ago by skvlad
Modified:
3 years, 10 months ago
Reviewers:
hta-webrtc, hbos, sakal
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of RTCInboundRTPStreamStats.qpSum collected. (patchset #4 id:80001 of https://codereview.webrtc.org/2675943002/ ) Reason for revert: Breaks downstream build. Original issue's description: > RTCInboundRTPStreamStats.qpSum collected. > > This was previously only collected for local tracks > (RTCOutboundRTPStreamStats.qpSum). > > Spec: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum > > This CL also improves some testing in rtcstatscollector_unittest.cc. > Default and non-default values are tested in the same unittests, > removing the test that was specific to default-values, which was > otherwise code duplication. > > BUG=webrtc:7065 > > Review-Url: https://codereview.webrtc.org/2675943002 > Cr-Commit-Position: refs/heads/master@{#16477} > Committed: https://chromium.googlesource.com/external/webrtc/+/cd195bea5e38a61e73b08f82445560d9136cd9da TBR=sakal@webrtc.org,hta@webrtc.org,hbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7065 Review-Url: https://codereview.webrtc.org/2687483002 . Cr-Commit-Position: refs/heads/master@{#16479} Committed: https://chromium.googlesource.com/external/webrtc/+/ed02c6d68f31baed3cfb7656062895a4d1cb7e65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -75 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 7 chunks +125 lines, -65 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
skvlad
Created Revert of RTCInboundRTPStreamStats.qpSum collected.
3 years, 10 months ago (2017-02-07 18:44:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687483002/1
3 years, 10 months ago (2017-02-07 18:44:31 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-07 18:44:33 UTC) #5
skvlad
Committed patchset #1 (id:1) manually as ed02c6d68f31baed3cfb7656062895a4d1cb7e65 (presubmit successful).
3 years, 10 months ago (2017-02-07 18:45:34 UTC) #7
hbos
lgtm
3 years, 10 months ago (2017-02-07 18:45:59 UTC) #8
hbos
Does this break downstream or is it a previous CL that this depends on that ...
3 years, 10 months ago (2017-02-07 18:46:47 UTC) #9
skvlad
3 years, 10 months ago (2017-02-07 19:00:30 UTC) #10
Message was sent while issue was closed.
On 2017/02/07 18:46:47, hbos wrote:
> Does this break downstream or is it a previous CL that this depends on that
> breaks it?

This CL depends on https://codereview.webrtc.org/2680893002/, which breaks the
build. Unfortunately, it appears that both need to be reverted.

Powered by Google App Engine
This is Rietveld 408576698