Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2687013005: Increase the send-time history to 60 seconds. (Closed)

Created:
3 years, 10 months ago by stefan-webrtc
Modified:
3 years, 10 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase the send-time history to 60 seconds. This helps us avoid time-outs on really bad networks with long queues. Also adding periodic logging of the fake network pipe's queue in milliseconds. BUG=webrtc:5079 Review-Url: https://codereview.webrtc.org/2687013005 Cr-Commit-Position: refs/heads/master@{#16532} Committed: https://chromium.googlesource.com/external/webrtc/+/e9ad271db4e0e2b3df8b21ca93e727c24838ffcf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter_unittest.cc View 2 chunks +67 lines, -0 lines 0 comments Download
M webrtc/test/fake_network_pipe.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/test/fake_network_pipe.cc View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
stefan-webrtc
3 years, 10 months ago (2017-02-10 10:32:25 UTC) #2
terelius
lgtm
3 years, 10 months ago (2017-02-10 13:58:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687013005/1
3 years, 10 months ago (2017-02-10 14:05:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 14:09:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e9ad271db4e0e2b3df8b21ca9...

Powered by Google App Engine
This is Rietveld 408576698