Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2686633002: Add new target direct_transport and remove fake_network and direct_transport from test_common. (Closed)

Created:
3 years, 10 months ago by perkj_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add new target direct_transport and remove fake_network and direct_transport from test_common. The purpose is to be able to use this feature without building and using all of test_common. However, test_common still builds call_test.cc that is depending on direct_transport. BUG=none Review-Url: https://codereview.webrtc.org/2686633002 Cr-Commit-Position: refs/heads/master@{#16494} Committed: https://chromium.googlesource.com/external/webrtc/+/488c5dcd8be47454344d767e2d0962f0fec45658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M webrtc/test/BUILD.gn View 4 chunks +20 lines, -5 lines 0 comments Download
M webrtc/test/direct_transport.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
perkj_webrtc
Please? This is to be able to use DirectTransport in an upstream project.
3 years, 10 months ago (2017-02-07 19:44:52 UTC) #4
ehmaldonado_webrtc
On 2017/02/07 19:44:52, perkj_webrtc wrote: > Please? > This is to be able to use ...
3 years, 10 months ago (2017-02-07 20:00:38 UTC) #5
perkj_webrtc
On 2017/02/07 20:00:38, ehmaldonado_webrtc wrote: > On 2017/02/07 19:44:52, perkj_webrtc wrote: > > Please? > ...
3 years, 10 months ago (2017-02-08 06:10:16 UTC) #8
ehmaldonado_webrtc
On 2017/02/08 06:10:16, perkj_webrtc wrote: > On 2017/02/07 20:00:38, ehmaldonado_webrtc wrote: > > On 2017/02/07 ...
3 years, 10 months ago (2017-02-08 12:20:51 UTC) #9
stefan-webrtc
lgtm
3 years, 10 months ago (2017-02-08 12:54:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2686633002/1
3 years, 10 months ago (2017-02-08 13:26:18 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 13:55:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/488c5dcd8be47454344d767e2...

Powered by Google App Engine
This is Rietveld 408576698