Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2686453004: Replace std::tr1::tuple by ::testing::tuple. (Closed)

Created:
3 years, 10 months ago by ehmaldonado_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace std::tr1::tuple by ::testing::tuple. BUG=webrtc:7129 NOTRY=True Review-Url: https://codereview.webrtc.org/2686453004 Cr-Commit-Position: refs/heads/master@{#16487} Committed: https://chromium.googlesource.com/external/webrtc/+/abcef5d32eeee7a5050873e6bec5a668addca405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M webrtc/pc/mediasession_unittest.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ehmaldonado_webrtc
3 years, 10 months ago (2017-02-07 19:54:09 UTC) #2
kjellander_webrtc
We need to implement a PRESUBMIT.py check for this if we want to avoid these ...
3 years, 10 months ago (2017-02-07 20:20:59 UTC) #3
kjellander_webrtc
lgtm, but you should track this with a bug (and I'm not owner here)
3 years, 10 months ago (2017-02-07 20:49:23 UTC) #4
Taylor Brandstetter
lgtm
3 years, 10 months ago (2017-02-07 21:42:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2686453004/1
3 years, 10 months ago (2017-02-07 21:57:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/1126)
3 years, 10 months ago (2017-02-07 22:10:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2686453004/1
3 years, 10 months ago (2017-02-08 12:04:36 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 12:07:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/abcef5d32eeee7a5050873e6b...

Powered by Google App Engine
This is Rietveld 408576698