Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

Issue 2686273002: Rename flexfec AddAndProcessReceivedPacket --> OnRtpPacket. (Closed)
Patch Set: Rename AddAndProcessReceivedPacket --> OnRtpPacket. Update tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc
diff --git a/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc b/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc
index b81a0399548dd67527d411abda6d2156bbaaaa05..42332629bfdab2607743a9f071158ade65a65eef 100644
--- a/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc
+++ b/webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc
@@ -45,13 +45,11 @@ FlexfecReceiver::FlexfecReceiver(
FlexfecReceiver::~FlexfecReceiver() = default;
-bool FlexfecReceiver::AddAndProcessReceivedPacket(
- const RtpPacketReceived& packet) {
+void FlexfecReceiver::OnRtpPacket(const RtpPacketReceived& packet) {
RTC_DCHECK_CALLED_SEQUENTIALLY(&sequence_checker_);
- if (!AddReceivedPacket(std::move(packet))) {
nisse-webrtc 2017/02/13 13:20:03 Does std::move make any sense here?
brandtr 2017/02/13 15:32:14 Nope, that is a mistake. Before, |packet| was pass
nisse-webrtc 2017/02/14 07:58:18 Deleted the move.
- return false;
+ if (AddReceivedPacket(std::move(packet))) {
+ ProcessReceivedPackets();
brandtr 2017/02/13 15:32:13 I prefer having the general case outside the brace
nisse-webrtc 2017/02/14 07:58:18 Done.
}
- return ProcessReceivedPackets();
}
FecPacketCounter FlexfecReceiver::GetPacketCounter() const {
« no previous file with comments | « webrtc/modules/rtp_rtcp/include/flexfec_receiver.h ('k') | webrtc/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698