Rename flexfec AddAndProcessReceivedPacket --> OnRtpPacket.

webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 27 matching lines @@
       recovered_packet_receiver_(recovered_packet_receiver),
       clock_(Clock::GetRealTimeClock()),
       last_recovered_packet_ms_(-1) {
   // It's OK to create this object on a different thread/task queue than
   // the one used during main operation.
   sequence_checker_.Detach();
 }
 
 FlexfecReceiver::~FlexfecReceiver() = default;
 
-bool FlexfecReceiver::AddAndProcessReceivedPacket(
-    const RtpPacketReceived& packet) {
+void FlexfecReceiver::OnRtpPacket(const RtpPacketReceived& packet) {
   RTC_DCHECK_CALLED_SEQUENTIALLY(&sequence_checker_);
-  if (!AddReceivedPacket(std::move(packet))) {

[nisse-webrtc, 2017/02/13 13:20:03]

Does std::move make any sense here?
 

[brandtr, 2017/02/13 15:32:14]

Nope, that is a mistake. Before, |packet| was passed by value, so then it made
sense.

[nisse-webrtc, 2017/02/14 07:58:18]

Deleted the move.

-    return false;
+  if (AddReceivedPacket(std::move(packet))) {
+    ProcessReceivedPackets();

[brandtr, 2017/02/13 15:32:13]

I prefer having the general case outside the braces:

if (!AddReceivedPacket(.)) {
  return;
}
ProcessReceivedPackets();

[nisse-webrtc, 2017/02/14 07:58:18]

Done.

   }
-  return ProcessReceivedPackets();
 }
 
 FecPacketCounter FlexfecReceiver::GetPacketCounter() const {
   RTC_DCHECK_CALLED_SEQUENTIALLY(&sequence_checker_);
   return packet_counter_;
 }
 
 bool FlexfecReceiver::AddReceivedPacket(const RtpPacketReceived& packet) {
   RTC_DCHECK_CALLED_SEQUENTIALLY(&sequence_checker_);
 
@@ skipping 80 matching lines @@
           ForwardErrorCorrection::ParseSsrc(recovered_packet->pkt->data);
       LOG(LS_VERBOSE) << "Recovered media packet with SSRC: " << media_ssrc
                       << " from FlexFEC stream with SSRC: " << ssrc_ << ".";
       last_recovered_packet_ms_ = now_ms;
     }
   }
   return true;
 }
 
 }  // namespace webrtc