Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2686003004: Remove unused voe_cpu_test.cc. (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused voe_cpu_test.cc. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2686003004 Cr-Commit-Position: refs/heads/master@{#16508} Committed: https://chromium.googlesource.com/external/webrtc/+/1752a107915d589948042e9eb31422f0f5bbbab9

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -144 lines) Patch
M webrtc/voice_engine/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/voe_cpu_test.h View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/voe_cpu_test.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_interface.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
the sun
3 years, 10 months ago (2017-02-09 08:33:43 UTC) #2
hlundin-webrtc
"Unused" might be a stretch, since you had to remove a bunch of lines where ...
3 years, 10 months ago (2017-02-09 08:45:20 UTC) #3
the sun
On 2017/02/09 08:45:20, hlundin-webrtc wrote: > "Unused" might be a stretch, since you had to ...
3 years, 10 months ago (2017-02-09 08:48:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2686003004/1
3 years, 10 months ago (2017-02-09 08:48:14 UTC) #6
commit-bot: I haz the power
Failed to apply patch for webrtc/voice_engine/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-09 09:49:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2686003004/20001
3 years, 10 months ago (2017-02-09 09:55:27 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 11:26:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1752a107915d589948042e9eb...

Powered by Google App Engine
This is Rietveld 408576698